-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allocation from width of character function. #48167
Remove allocation from width of character function. #48167
Conversation
@bors r+ rollup |
📌 Commit f237e9e has been approved by |
I've nominated this for beta backport, as it's a small patch that fixes a major regression (40 minute long compile times vs 150 seconds), and if we cut beta before this lands (likely) this is good to get in. |
…odemap, r=estebank Remove allocation from width of character function. Locally this seems to eliminate the problem or at least resolve most of the issue. Fixes rust-lang#48153. r? @estebank
…odemap, r=estebank Remove allocation from width of character function. Locally this seems to eliminate the problem or at least resolve most of the issue. Fixes rust-lang#48153. r? @estebank
@rust-lang/release Would anyone be interested in making a beta backport of this? Process is described here: https://forge.rust-lang.org/beta-backporting.html |
@Mark-Simulacrum I'll take this one if it's no problem. |
[beta] Remove allocation from width of character function. Backport of #48167 r? @Mark-Simulacrum
[beta] Remove allocation from width of character function. Backport of #48167 r? @Mark-Simulacrum
Locally this seems to eliminate the problem or at least resolve most of the
issue.
Fixes #48153.
r? @estebank