Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move macro-at-most-once-rep-ambig test to ui test #48302

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Move macro-at-most-once-rep-ambig test to ui test #48302

merged 1 commit into from
Feb 25, 2018

Conversation

mark-i-m
Copy link
Member

I had written this test for the feature. Now moving to ui test.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2018
@arazabishov
Copy link
Member

Ping from triage @aturon :) Any chance that you had time to look at this PR?

@aturon
Copy link
Member

aturon commented Feb 23, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 23, 2018

📌 Commit 6ad328c has been approved by aturon

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018
@Manishearth Manishearth mentioned this pull request Feb 25, 2018
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 25, 2018
@Manishearth
Rollup merge of rust-lang#48302 - mark-i-m:markim_macro-test, r=aturon
52bd669 
Move macro-at-most-once-rep-ambig test to ui test

I had written this test for the feature. Now moving to ui test.
kennytm added a commit to kennytm/rust that referenced this pull request Feb 25, 2018
@kennytm
Rollup merge of rust-lang#48302 - mark-i-m:markim_macro-test, r=aturon
6627cba 
Move macro-at-most-once-rep-ambig test to ui test

I had written this test for the feature. Now moving to ui test.
@kennytm kennytm mentioned this pull request Feb 25, 2018
Merged
bors added a commit that referenced this pull request Feb 25, 2018
@bors
Auto merge of #48531 - kennytm:rollup, r=kennytm
322d7f7 
Rollup of 17 pull requests

- Successful merges: #47964, #47970, #48076, #48115, #48166, #48281, #48297, #48302, #48362, #48369, #48489, #48491, #48494, #48517, #48529, #48235, #48330
- Failed merges:
@bors bors merged commit 6ad328c into rust-lang:master Feb 25, 2018
@mark-i-m mark-i-m deleted the markim_macro-test branch November 14, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mark-i-m @rust-highfive @arazabishov @aturon @bors