Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nightly to 1.26.0 and bootstrap from beta. #48343

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Update nightly to 1.26.0 and bootstrap from beta. #48343

merged 2 commits into from
Feb 23, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 18, 2018 •
edited
Loading

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 18, 2018
Keruspe
Keruspe reviewed Feb 19, 2018
View reviewed changes
src/stage0.txt Outdated
@@ -12,7 +12,7 @@
# source tarball for a stable release you'll likely see `1.x.0` for rustc and
# `0.x.0` for Cargo where they were released on `date`.

date: 2018-01-02
date: 2018-01-18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that be 2018-02-18 rather that 01?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you.

@Mark-Simulacrum
Copy link
Member Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned aturon Feb 19, 2018
@kennytm
Copy link
Member

kennytm commented Feb 20, 2018

r=me after Travis passed (a beta is released)

@Mark-Simulacrum Mark-Simulacrum force-pushed the release-step branch 2 times, most recently from d14d162 to 33f5cee Compare February 20, 2018 19:37
@Mark-Simulacrum
Copy link
Member Author

Reverted the cargo dependency bump since that causes the double-rand crate conflict. Otherwise, though, should be fine, so @bors r=kennytm p=1

@bors
Copy link
Contributor

bors commented Feb 20, 2018

📌 Commit 33f5cee has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2018
@bors
Copy link
Contributor

bors commented Feb 21, 2018

⌛ Testing commit 33f5cee with merge 7a7607b...

bors added a commit that referenced this pull request Feb 21, 2018
@bors
Auto merge of #48343 - Mark-Simulacrum:release-step, r=kennytm
7a7607b 
Update nightly to 1.26.0 and bootstrap from beta.
@bors
Copy link
Contributor

bors commented Feb 21, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2018
@kennytm
Copy link
Member

kennytm commented Feb 21, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2018
@bors
Copy link
Contributor

bors commented Feb 21, 2018

⌛ Testing commit 33f5cee with merge fad94616b2e0088c410401dab06584dbda72536e...

@bors
Copy link
Contributor

bors commented Feb 21, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2018
@kennytm
Copy link
Member

kennytm commented Feb 21, 2018

@bors retry

dist-{armv7,armhf}-linux 3-hour timed out.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2018
@bors
Copy link
Contributor

bors commented Feb 22, 2018

⌛ Testing commit 33f5cee with merge 78e507cf15cb4ff676fa6dcfbb368d127017feb3...

@bors
Copy link
Contributor

bors commented Feb 22, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2018
@kennytm
Copy link
Member

kennytm commented Feb 22, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2018
@bors
Copy link
Contributor

bors commented Feb 22, 2018

⌛ Testing commit 33f5cee with merge 9d58e44ca50d6defc381713bb29ad7f89e7db608...

@bors
Copy link
Contributor

bors commented Feb 22, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2018
@kennytm
Copy link
Member

kennytm commented Feb 22, 2018

@bors retry

3 hour timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2018
@bors
Copy link
Contributor

bors commented Feb 22, 2018

⌛ Testing commit 33f5cee with merge 5de9089...

bors added a commit that referenced this pull request Feb 22, 2018
@bors
Auto merge of #48343 - Mark-Simulacrum:release-step, r=kennytm
5de9089 
Update nightly to 1.26.0 and bootstrap from beta.
@bors
Copy link
Contributor

bors commented Feb 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 5de9089 to master...

@bors bors merged commit 33f5cee into rust-lang:master Feb 23, 2018
@bors bors mentioned this pull request Feb 23, 2018
Merged
@Mark-Simulacrum Mark-Simulacrum deleted the release-step branch June 8, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keruspe Keruspe Keruspe left review comments

Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mark-Simulacrum @rust-highfive @kennytm @bors @Keruspe @aturon