Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root-path #48442

Closed
wants to merge 1 commit into from
Closed

Conversation

GuillaumeGomez
Copy link
Member

r? @QuietMisdreavus

cc @onur

I tested everything that came to my mind but I'm pretty sure I didn't think of a corner case where this feature could break. Any feedback/additional tests would be very appreciated. :)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2018
@onur
Copy link
Member

onur commented Feb 23, 2018

Hi @GuillaumeGomez, this is great, I haven't tested it yet but there are some issues:

  1. This won't allow me to add a version subfix to commonly used files. It's still not compatible with theme picker. JavaScript portion of theme picker is only working with dark.css and rustdoc.css. That's the main reason why theme picker did break docs.rs. I have to add a rustc version to this files in order to keep compatibility between docs generated with the old versions of rustc.
  2. search-index.js is usually different for each create, I am not moving it in docs.rs and keeping it in doc/ directory of every crate.

I'll test it as soon as I find some time and return to you if I find anymore issue.

Your --url or --replace idea is actually exactly what I am looking for instead of generating this files in another location. But thanks to you I know where to look at for this feature now, maybe I can help with a solution.

@GuillaumeGomez
Copy link
Member Author

Ok, writing a second PR which adds an resource-suffic option.

@shepmaster
Copy link
Member

Ping from triage, @QuietMisdreavus !

@GuillaumeGomez
Copy link
Member Author

I'll close this PR in favor of #48511.

@GuillaumeGomez GuillaumeGomez deleted the root-path branch March 3, 2018 15:36
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
…fix, r=QuietMisdreavus

Add resource-suffix option for rustdoc

Alternative version of rust-lang#48442.

cc @onur

r? @QuietMisdreavus
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
…fix, r=QuietMisdreavus

Add resource-suffix option for rustdoc

Alternative version of rust-lang#48442.

cc @onur

r? @QuietMisdreavus
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 7, 2018
…fix, r=QuietMisdreavus

Add resource-suffix option for rustdoc

Alternative version of rust-lang#48442.

cc @onur

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants