Update rustc --explain sentence

[GuillaumeGomez]

Fixes @zackmdavis' concern.

[rust-highfive]

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

Mentioned @zackmdavis' concern: #48337 (comment)

[petrochenkov]

"rustc --explain E0453" -> `rustc --explain E0453`

[petrochenkov]

Since we start with a capital letter (seems appropriate here) then we should probably end with a dot.

[petrochenkov]

@zackmdavis What do you think about "You've got a few errors" above?

[petrochenkov]

Also, do we have an English language expert here? Is the comma before "try" correct?

[zackmdavis]

What do you think about "You've got a few errors" above?

I'd prefer "There were some errors" or "Some errors occurred."

Others might disagree with my style æsthetics, but to me, the second person (addressing the user as "you") and contractions feel like too much attempted folksiness in contrast to the "serious", "no-nonsense" tone I expect from compiler error messages.

Is the comma before "try" correct?

Yes, it's separating a dependent clause from a subsequent independent clause.

[petrochenkov]

I agree with @zackmdavis here.

@GuillaumeGomez
Could you make the mentioned changes and then squash into 1 commit?

We should get this right on the first try (no grammatical errors, etc), I'd really like to avoid landing one more "+1,040 −1,042" PR potentially conflicting with any other PR changing UI tests.

[GuillaumeGomez]

I'll wait for your questions to have answers before updating @petrochenkov. 😄

BTW, here's the python script I used this time:

from os import listdir
from os.path import isdir, isfile, join

PATHS = ["src/test/ui", "src/test/ui-fulldeps"]

def do_something(path):
    files = [join(path, f) for f in listdir(path)]

    for f in files:
        if isdir(f):
            do_something(f)
            continue
        if not isfile(f) or not f.endswith(".stderr"):
            continue
        x = open(f, "r")
        content = x.read()
        if "error[E" not in content:
            continue
        x = open(f, "w")
        x.write(content.replace("If you want more information on an error, try using",
                                "For more information about an error, try")
                       .replace("If you want more information on this error, try using",
                                "For more information about this error, try"))

for path in PATHS:
    do_something(path)

[zackmdavis]

Frequent diagnostics contributors @oli-obk and @estebank might have opinions?

[petrochenkov]

@GuillaumeGomez
Why did you need a separate script? src/test/ui/update-all-references.sh and src/test/ui-fulldeps/update-all-references.sh update stderr files for any changes.

[petrochenkov]

Missing dot (same as #48559 (comment)).

[GuillaumeGomez]

@petrochenkov: I didn't know such a script existed and it took me 5 minutes to write the python one so not really an issue...

We should get this right on the first try (no grammatical errors, etc), I'd really like to avoid landing one more "+1,040 −1,042" PR potentially conflicting with any other PR changing UI tests.

That's what review are normally for (it certainly annoys me more than you). :)

[petrochenkov]

LGTM, but let's wait until the situation about #48562 is resolved.

[bors]

☔ The latest upstream changes (presumably #48125) made this pull request unmergeable. Please resolve the merge conflicts.

[petrochenkov]

Closing in favor of #48684 that does same rewording.