Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #48577

Closed
wants to merge 32 commits into from
Closed

Rollup of 13 pull requests #48577

wants to merge 32 commits into from

Commits on Feb 19, 2018

  1. Add non-panicking variants of pow to all integer types

    Currently, calling pow may panic in case of overflow, and the function
    does not have non-panicking counterparts. Thus, it would be beneficial
    to add those in.
    milesand committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    b31ff95 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2018

  1. Configuration menu
    Copy the full SHA
    2d3f31d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b61b61 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d51c33 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Configuration menu
    Copy the full SHA
    b1a6c8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2985a1a View commit details
    Browse the repository at this point in the history
  3. Handle gdb command failure gracefully in compiletest

    Previously, if the gdb command was available, but threw an error, compiletest would panic.  This is obviously not good. Now, gdb is treated as missing if calling `gdb --version` does not output anything on stdout.
    varkor committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    70db41c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Configuration menu
    Copy the full SHA
    23dc694 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2018

  1. Restrict the Termination impls to simplify stabilization

    Make a minimal commitment for stabilization.  More impls are likely in future, but are not necessary at this time.
    scottmcm committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    e20f7b2 View commit details
    Browse the repository at this point in the history
  2. Ensure main() always has external linkage

    This ensures that the entry function is never elided due to inlining, even with `inline(always)`. Fixes rust-lang#47783.
    
    There were a couple of possible ways of addressing this issue; I simply picked the one that seemed most direct. A warning could be appropriate, but considering using inlining hints in other places it doesn't apply also throws no warnings, and it seems like an edge case anyway, I haven't added one for now.
    varkor committed Feb 25, 2018
    Configuration menu
    Copy the full SHA
    2466644 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2018

  1. Configuration menu
    Copy the full SHA
    88de279 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a22fbf8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b7683a3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7c84ba4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5db73fc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2026453 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    279e5b0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9c80019 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c133a08 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Rollup merge of rust-lang#48266 - pietroalbini:report-compiler-flags-…

    …on-ice, r=michaelwoerister
    
    Report non-standard compile flags on ICE
    
    Some ICEs (such as the recent rust-lang#48248) only happens when a non-standard compiler flag is provided to rustc, but users don't always report the used flags. This can slow down reproducing the issue, so this PR shows all the non-standard compiler flags in the ICE error message.
    
    For example, the output of rust-lang#48248 with this PR is:
    
    ```
    error: internal compiler error: [...]
    
    thread 'rustc' panicked at [...]
    note: Run with `RUST_BACKTRACE=1` for a backtrace.
    
    note: the compiler unexpectedly panicked. this is a bug.
    
    note: we would appreciate a bug report: [...]
    
    note: rustc 1.25.0-dev running on x86_64-unknown-linux-gnu
    
    note: compiler flags: -C link-dead-code
    ```
    
    ### Open questions
    
    * At the moment, only `-C` and `-Z` flags are shown by default, and all the ones provided by cargo in a standard build are ignored: I did this to only show the flags that probably caused the ICE, and to remove some noise from the message. This removed flags like `opt-level` and `debuginfo` though, could those be useful for reproducing ICEs?
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    0b42c74 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#48321 - milesand:no_panic_pow, r=alexcrichton

    Add non-panicking variants of pow for integer types
    
    Currently, calling pow may panic in case of overflow, and the function does not have non-panicking counterparts. Thus, it would be beneficial to add those in.
    
    Closes rust-lang#48291.
    Relevant tracking issue: rust-lang#48320
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    a6820ce View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#48450 - frewsxcv:frewsxcxv-stabilize-slice-…

    …rotatee, r=alexcrichton
    
    Stabilize [T]::rotate_{left,right}
    
    rust-lang#41891
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    b106016 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#48473 - GuillaumeGomez:rustdoc-auto-trait-i…

    …mpl-fix, r=QuietMisdreavus
    
    Fix auto trait impl rustdoc ice
    
    Fixes rust-lang#48463.
    
    r? @QuietMisdreavus
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    d93440c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#48484 - glaubitz:powerpcspe-linux, r=alexcr…

    …ichton
    
    Add support for powerpc-unknown-linux-gnuspe
    
    This PR adds support for the embedded PowerPC variant "e500". On Linux, this architecture is usually called "powerpcspe", it is a 32-bit PowerPC architecture. The main difference between normal 32-bit PowerPC and PowerPCSPE is the lack of Altivec instructions and the additional SPE instruction set.
    
    This architecture is supported in Debian through an unofficial port.
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    70f1de1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#48488 - varkor:handle-gdb-error-compiletest…

    …, r=michaelwoerister
    
    Handle gdb command failure gracefully in compiletest
    
    Previously, if the gdb command was available, but threw an error, compiletest would panic.  This is obviously not good. Now, gdb is treated as missing if calling `gdb --version` does not output anything on stdout.
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    d678890 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#48497 - scottmcm:more-restricted-terminatio…

    …n, r=nikomatsakis
    
    Restrict the Termination impls to simplify stabilization
    
    Make a minimal commitment in preparation for stabilization.  More impls, or broader ones, are likely in future, but are not necessary at this time and are more controversial.
    
    cc rust-lang#48453 (comment)
    r? @nikomatsakis
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    d5ac422 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#48541 - varkor:inlined-main, r=michaelwoeri…

    …ster
    
    Ensure main() always has external linkage
    
    This ensures that the entry function is never elided due to inlining, even with `inline(always)`. Fixes rust-lang#47783.
    
    There were a couple of possible ways of addressing this issue; I simply picked the one that seemed most direct. A warning could be appropriate, but considering using inlining hints in other places it doesn't apply also throws no warnings, and it seems like an edge case anyway, I haven't added one for now.
    kennytm authored Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8b3b254 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#48558 - Mark-Simulacrum:error-format, r=Man…

    …ishearth
    
    Fix error-format to properly send JSON to stdout
    
    Since we take Cargo's JSON messages as well we need to specifically send
    rustc's messages out so we don't hide them.
    
    r? @Manishearth
    kennytm committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    5805538 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#48560 - bdrewery:freebsd-struct-abi, r=este…

    …bank
    
    Fix FreeBSD struct returning ABI.
    
    FreeBSD has had a patch similar to this for a while. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223047.
    
    This reworks 6774e7a to be more specific about what `compute_abi_info` is checking for per target.
    kennytm committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    4fcee2b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#48565 - alexcrichton:rename-bmi, r=cramertj

    rustc: Rename `bmi` feature to `bmi1`
    
    This is what [Intel calls it][bmi1] and will [remove a special case][stdsimd]
    when verifying intrinsics in stdsimd.
    
    [bmi1]: https://software.intel.com/sites/landingpage/IntrinsicsGuide/#othertechs=BMI1
    [stdsimd]: https://github.com/rust-lang-nursery/stdsimd/blob/bed25b2a9f3b28e6ea80de6d87842f739a2e2d58/crates/stdsimd-verify/tests/x86-intel.rs#L252-L258
    kennytm committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    5cd8eb2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#48381 - GuillaumeGomez:rustdoc-theme-securi…

    …ties, r=QuietMisdreavus
    
    Rustdoc theme securities rust-lang#48381
    
    Fixes rust-lang#48375.
    Fixes rust-lang#48376.
    kennytm committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    8bdad67 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#48548 - alexcrichton:msvc-linker-utf16, r=a…

    …lexcrichton
    
    Encode linker arguments as UTF-16 on MSVC platforms
    
    This is a forward-port of rust-lang#48455 to the master branch
    kennytm committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    2b114da View commit details
    Browse the repository at this point in the history