Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "correct subtle bug in the type variable code" #48666

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Mar 2, 2018

This reverts commit ccd92c2.

This commit is the source of a major perf regression, and was not
intended to be included in #47861. At some point I must have
accidentally re-added the commit.

Fixes #48660.

r? @nikomatsakis

This reverts commit ccd92c2.

This commit is the source of a major perf regression, and was not
intended to be included in rust-lang#47861. At some point I must have
accidentally re-added the commit.
@sgrif
Copy link
Contributor Author

sgrif commented Mar 2, 2018

/cc @Mark-Simulacrum @rust-lang/release needs perf

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2018
@nikomatsakis
Copy link
Contributor

@bors r+ p=1 -- this corrects a major perf regression. We already know that it has a big impact since we measured before, let's just land and observe the effect.

@bors
Copy link
Contributor

bors commented Mar 2, 2018

📌 Commit f5f53e9 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2018
@kennytm
Copy link
Member

kennytm commented Mar 2, 2018

@bors p=5

Because everything else is currently p=2 😄

@kennytm
Copy link
Member

kennytm commented Mar 3, 2018

@bors p=50

@bors
Copy link
Contributor

bors commented Mar 3, 2018

⌛ Testing commit f5f53e9 with merge 5f1f628...

bors added a commit that referenced this pull request Mar 3, 2018
Revert "correct subtle bug in the type variable code"

This reverts commit ccd92c2.

This commit is the source of a major perf regression, and was not
intended to be included in #47861. At some point I must have
accidentally re-added the commit.

Fixes #48660.

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Mar 3, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5f1f628 to master...

@bors bors merged commit f5f53e9 into rust-lang:master Mar 3, 2018
@sgrif
Copy link
Contributor Author

sgrif commented Mar 4, 2018

Thanks for the p bump @kennytm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants