-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "correct subtle bug in the type variable code" #48666
Conversation
This reverts commit ccd92c2. This commit is the source of a major perf regression, and was not intended to be included in rust-lang#47861. At some point I must have accidentally re-added the commit.
/cc @Mark-Simulacrum @rust-lang/release needs perf |
@bors r+ p=1 -- this corrects a major perf regression. We already know that it has a big impact since we measured before, let's just land and observe the effect. |
📌 Commit f5f53e9 has been approved by |
@bors p=5 Because everything else is currently p=2 😄 |
@bors p=50 |
Revert "correct subtle bug in the type variable code" This reverts commit ccd92c2. This commit is the source of a major perf regression, and was not intended to be included in #47861. At some point I must have accidentally re-added the commit. Fixes #48660. r? @nikomatsakis
☀️ Test successful - status-appveyor, status-travis |
Thanks for the p bump @kennytm |
This reverts commit ccd92c2.
This commit is the source of a major perf regression, and was not
intended to be included in #47861. At some point I must have
accidentally re-added the commit.
Fixes #48660.
r? @nikomatsakis