Rollup of 7 pull requests #48897
Closed
Rollup of 7 pull requests #48897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally I'd like to soon enable sccache for rustbuild itself and some of the stage0 tools, but for that to work we'll need some better Rust support than the pretty old version we were previously using!
This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
All cases where it is used can be replaced by substituing run.host for run.builder.build.build; that is its only effect. As such, it is removable.
All uses are replaced with not accessing run.target/run.host, and instead directly using run.builder.build.build.
Previously it was set to true when we didn't run HOSTS steps.
rustbuild: pass datadir to rust-installer This fixes zsh completion install when $datadir != $prefix/share
…tep-1, r=alexcrichton Remove ONLY_BUILD and ONLY_BUILD_TARGETS Primarily removes `ONLY_BUILD` and `ONLY_BUILD_TARGETS`. These aren't actually needed in the new system since we can simply not take the relevant `host` and `target` fields if we don't want to run with them in `Step::make_run`. This PR also includes a few other commits which generally clean up the state of rustbuild, but are not related to the `Step` changes.
Update sccache to its master branch Ideally I'd like to soon enable sccache for rustbuild itself and some of the stage0 tools, but for that to work we'll need some better Rust support than the pretty old version we were previously using!
…etMisdreavus Multiple rustdoc fixes Fixes rust-lang#48733. r? @QuietMisdreavus
…-Simulacrum travis: Upgrade OSX builders This upgrades the OSX builders to the `xcode9.3-moar` image which has 3 cores as opposed to the 2 that our builders currently have. Should help make those OSX builds a bit speedier!
…=QuietMisdreavus Add missing urls r? @QuietMisdreavus
tidy: Add a check for stray `.stderr` and `.stdout` files in UI test directories
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=10 |
|
📌 Commit 56b923e has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 56b923e with merge 2215b23e071593b73ba455c4bc2ae8aefa29fc12... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
|
@bors retry -- 30minute no output on os x, which is somewhat odd |
bors
added
S-waiting-on-bors
|
@bors: r- That's almost for sure sccache's fault |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.stderrand.stdoutfiles in UI test directories #48880