Easy edition feature flag #49252
Easy edition feature flag #49252
Conversation
rust-highfive
added
the
S-waiting-on-review
kennytm
added
S-blocked
|
|
||
| pub fn feature_name(&self) -> &'static str { | ||
| match *self { | ||
| Edition::Edition2015 => "rust_2015_preview", |
There was a problem hiding this comment.
Avoiding the anachronism of "preview" may be more valuable than keeping these names symmetrical?
There was a problem hiding this comment.
No, once a feature is added it can't be "removed" completely.
There's no way to use the rust_2015_preview feature, that feature exists only so that attempting to use it will throw a "feature removed" warning. This goes for the 2018_preview feature when you enable the 2018 epoch, as well.
Yes, we could just not do this for 2015, but it didn't seem worth it to special case 2015.
|
Sorry @Manishearth, didn't get to this yesterday and may not today. I suck. As far as feature flags go, a preliminary list would be the features found here: though some of those are rapidly stabilizing. I can come around for a more complete list soon. |
|
☔ The latest upstream changes (presumably #49308) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
force-pushed
the
easy-feature-flag
branch
from
4dd01d5
to
b622870
Compare
| for &(.., f_edition, set) in ACTIVE_FEATURES.iter() { | ||
| if let Some(f_edition) = f_edition { | ||
| if edition >= f_edition { | ||
| // FIXME(Manishearth) there is currently no way to set |
Manishearth
force-pushed
the
easy-feature-flag
branch
from
b622870
to
45f9aab
Compare
Manishearth
force-pushed
the
easy-feature-flag
branch
from
45f9aab
to
195c6b4
Compare
|
Done |
shepmaster
added
S-blocked
|
@bors r+ |
|
📌 Commit 195c6b4 has been approved by |
bors
added
S-waiting-on-bors
Easy edition feature flag We no longer gate features on epochs; instead we have a `#![feature(rust_2018_preview)]` that flips on a bunch of features (currently dyn_trait). Based on #49001 to avoid merge conflicts r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
We no longer gate features on epochs; instead we have a
#![feature(rust_2018_preview)]that flips on a bunch of features (currently dyn_trait).Based on #49001 to avoid merge conflicts
r? @nikomatsakis