Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize fs::read and fs::write #49422

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Stabilize fs::read and fs::write #49422

merged 1 commit into from
Mar 30, 2018

Conversation

mbrubeck
Copy link
Contributor

As discussed in #46588 (comment)

@rust-highfive
Copy link
Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@mbrubeck
Copy link
Contributor Author

This fails tidy because the the still-unstable fs::read_string has the same feature name as these stabilized functions. What's the preferred solution here? Change the feature name in the new #[stable] attributes, maybe? (Or we could change the feature for read_string but this would be slightly more disruptive to existing unstable code.)

@scottmcm
Copy link
Member

I like just changing the feature to fs_read_write_bytes or something. I don't think the feature name actually matters so, as you say, not breaking nightly seem nicer.

@mbrubeck
Copy link
Contributor Author

I like just changing the feature to fs_read_write_bytes or something.

Done.

@TimNN
Copy link
Contributor

TimNN commented Mar 29, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Mar 29, 2018

📌 Commit 0600d0f has been approved by TimNN

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2018
@kennytm kennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 29, 2018
@kennytm
Copy link
Member

kennytm commented Mar 29, 2018

Remember to change the version to 1.26.0 if this merges before someone has got time to branch the beta.

@bors
Copy link
Contributor

bors commented Mar 29, 2018

⌛ Testing commit 0600d0f with merge a51aa6a08de689ce61f43d27ecc76448155dc627...

@bors
Copy link
Contributor

bors commented Mar 29, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2018
@mbrubeck
Copy link
Contributor Author

One of the appveyor jobs hit the 3 hour limit. Can someone retry it?

@TimNN
Copy link
Contributor

TimNN commented Mar 30, 2018 via email

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2018
@bors
Copy link
Contributor

bors commented Mar 30, 2018

⌛ Testing commit 0600d0f with merge 6960761...

bors added a commit that referenced this pull request Mar 30, 2018
@bors
Auto merge of #49422 - mbrubeck:fs_read, r=TimNN
6960761 
Stabilize fs::read and fs::write

As discussed in #46588 (comment)
@bors
Copy link
Contributor

bors commented Mar 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: TimNN
Pushing 6960761 to master...

@bors bors merged commit 0600d0f into rust-lang:master Mar 30, 2018
@TimNN
Copy link
Contributor

TimNN commented Mar 30, 2018

Remember to change the version to 1.26.0 if this merges before someone has got time to branch the beta.

Oh, it looks like I misinterpreted one of the commits on the beta branch. It looks like we'll indeed need to change the versions.

This was referenced Mar 30, 2018
Merged
Closed
bors added a commit that referenced this pull request Mar 31, 2018
@bors
Auto merge of #49521 - mbrubeck:fs_read_write_bytes, r=TimNN
517f240 
fs_read_write_bytes stabilized in 1.26.0

Fix the stabilization attributes from #49422 because it merged before 1.26 branched to beta.

r? @TimNN
@kennytm kennytm mentioned this pull request Apr 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TimNN TimNN

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbrubeck @rust-highfive @scottmcm @TimNN @bors @kennytm