Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rc<str> and Rc<[T]> instead of Rc<String> and Rc<Vec<T>> #49645

Closed
wants to merge 3 commits into from
Closed

Use Rc<str> and Rc<[T]> instead of Rc<String> and Rc<Vec<T>> #49645

wants to merge 3 commits into from

Commits on Apr 7, 2018

  1. Use Rc<str> instead of Rc<String> in HashMap docs

    @birkenfeld
    birkenfeld committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    e3ff397 View commit details
    Browse the repository at this point in the history

  2. Use Lrc<[u8]/str> instead of Lrc<Vec<u8>/String> in libsyntax

    @birkenfeld
    birkenfeld committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    30b5d76 View commit details
    Browse the repository at this point in the history

  3. Use Lrc<[T]> instead of Lrc<Vec<T>> in librustc 

    There is one instace where Lrc::get_mut().unwrap() is used on
the reference to make a push, this cannot be converted.

One instance of Lrc::make_mut() was removed -- the side effect of
changing the original vector cannot have mattered since make_mut()
might have cloned it.
    @birkenfeld
    birkenfeld committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    14e7974 View commit details
    Browse the repository at this point in the history