add regression test for #16223 (NLL): use of collaterally moved value #49781
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
| if let box SetOfVariants { | ||
| lhs: SomeVariant::A(a), | ||
| rhs: SomeVariant::B(b), | ||
| } = root.boxed |
There was a problem hiding this comment.
You can use *root.boxed here if you want to avoid the box pattern.
There was a problem hiding this comment.
Thank you for the code review!
Your suggested code works and maybe this test should go with a dereference.
I haven't dereferenced root.boxed because it covers a nice use case where the entire root.boxed is only conditionally moved into the then-case of the if and otherwise can be further processed - this is not possible if you explicitely dereference it.
I use this convenience a lot in my current project and at least to me it would be nice if this functionality was tested, too.
|
@bors r+ rollup Thanks! |
|
📌 Commit f62c210 has been approved by |
bors
added
S-waiting-on-bors
add regression test for rust-lang#16223 (NLL): use of collaterally moved value Adds regression test for rust-lang#16223 which NLL fixes. The current downside of this test is that it uses the `#![feature(box_patterns)]` and I haven't come up with a proper test that only uses the `#![feature(nll)]` - however, I don't know if this is even possible to test without `#![feature(box_syntax)]` or `#![feature(box_patterns)]`.
Rollup of 14 pull requests Successful merges: - #49525 (Use sort_by_cached_key where appropriate) - #49575 (Stabilize `Option::filter`.) - #49614 (in which the non-shorthand patterns lint keeps its own counsel in macros) - #49665 (Small nits to make couple of tests pass on mips targets.) - #49781 (add regression test for #16223 (NLL): use of collaterally moved value) - #49795 (Properly look for uninhabitedness of variants in niche-filling check) - #49809 (Stop emitting color codes on TERM=dumb) - #49856 (Do not uppercase-lint #[no_mangle] statics) - #49863 (fixed typo) - #49857 (Fix "fp" target feature for AArch64) - #49849 (Add --enable-debug flag to musl CI build script) - #49734 (proc_macro: Generalize `FromIterator` impl) - #49730 (Fix ICE with impl Trait) - #48270 (Replace `structurally_resolved_type` in casts check.) Failed merges:
Adds regression test for #16223 which NLL fixes.
The current downside of this test is that it uses the
#![feature(box_patterns)]and I haven't come up with a proper test that only uses the#![feature(nll)]- however, I don't know if this is even possible to test without#![feature(box_syntax)]or#![feature(box_patterns)].