Rename rustc_back to rustc_target and move ABI code to it. #50228

irinagpopa · 2018-04-25T16:46:51Z

Fixes #45226.

rust-highfive · 2018-04-25T16:46:55Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2018-04-25T16:50:21Z

r? @nikomatsakis or @michaelwoerister cc @alexcrichton

nikomatsakis · 2018-04-25T16:56:15Z

@bors r+

bors · 2018-04-25T16:56:16Z

📌 Commit 770ff66 has been approved by nikomatsakis

rust-highfive · 2018-04-25T16:56:23Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:57] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:57] tidy error: /checkout/src/librustc_target/abi/mod.rs:797: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/mod.rs: missing trailing newline
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mips.rs:47: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mips64.rs:30: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mips64.rs:44: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mips64.rs:86: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mips64.rs:154: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/powerpc64.rs:25: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/powerpc64.rs:29: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc.rs:14: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/mod.rs:248: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/arm.rs:16: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/arm.rs:80: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/arm.rs:104: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/x86_64.rs:35: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/x86_64.rs:40: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/x86_64.rs:182: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/asmjs.rs:19: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/asmjs.rs:45: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/aarch64.rs:15: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/aarch64.rs:44: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/aarch64.rs:78: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/aarch64.rs:112: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:19: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:44: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:46: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:81: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:83: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:107: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/sparc64.rs:109: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/s390x.rs:17: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/s390x.rs:49: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/s390x.rs:75: trailing whitespace
[00:04:57] tidy error: /checkout/src/librustc_target/abi/call/x86.rs:43: trailing whitespace
[00:04:58] tidy error: /checkout/src/libsyntax/test.rs:566: line longer than 100 chars
[00:04:58] tidy error: /checkout/src/librustc/ty/context.rs:1207: trailing whitespace
[00:04:58] tidy error: /checkout/src/librustc/ty/layout.rs:1443: trailing whitespace
[00:04:59] some tidy checks failed
[00:04:59] 
[00:04:59] 
[00:04:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:59] 
[00:04:59] 
[00:04:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:59] Build completed unsuccessfully in 0:01:55
[00:04:59] Build completed unsuccessfully in 0:01:55
[00:04:59] Makefile:79: recipe for target 'tidy' failed
[00:04:59] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:26f04f4b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-04-25T16:58:24Z

@bors r- -- travis failures

nikomatsakis · 2018-04-25T16:58:37Z

Looks like you gotta run tidy =)

eddyb · 2018-04-26T13:17:42Z

@bors r=nikomatsakis p=10 (to prevent bitrot)

bors · 2018-04-26T13:17:42Z

📌 Commit 80bcbbf has been approved by nikomatsakis

bors · 2018-04-26T13:24:39Z

🔒 Merge conflict

rust-highfive · 2018-04-26T13:31:19Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:07:15]    Compiling rustc_const_math v0.0.0 (file:///checkout/src/librustc_const_math)
[00:07:35]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:14:09]    Compiling rustc_typeck v0.0.0 (file:///checkout/src/librustc_typeck)
[00:14:09]    Compiling rustc_mir v0.0.0 (file:///checkout/src/librustc_mir)
[00:14:21] error[E0599]: no variant named `from_attr` found for type `rustc_target::abi::Integer` in the current scope
[00:14:21]    --> librustc_mir/interpret/eval_context.rs:885:36
[00:14:21]     |
[00:14:21] 885 |                     let discr_ty = layout::Integer::from_attr(self.tcx.tcx, discr_ty);
[00:14:21]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ variant not found in `rustc_target::abi::Integer`
[00:14:21]     |
[00:14:21]     = help: items from traits can only be used if the trait is in scope
[00:14:21]     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
[00:14:21]             candidate #1: `use rustc::ty::layout::IntegerExt;`
[00:14:23] error: aborting due to previous error
[00:14:23] 
[00:14:23] For more information about this error, try `rustc --explain E0599`.
[00:14:23] error: Could not compile `rustc_mir`.
[00:14:23] error: Could not compile `rustc_mir`.
[00:14:23] 
[00:14:23] Caused by:
[00:14:23]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_mir librustc_mir/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=8beb98c628ea2fc1 -C extra-filename=-8beb98c628ea2fc1 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern syntax=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-21033e7d98b3b734.so --extern rustc_apfloat=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-521818bd083c928c.rlib --extern arena=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-0b7f7b8330cb09ce.so --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-de29d22526477961.so --extern log_settings=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog_settings-70f7ed359bd54256.rlib --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-550afbc40330c44b.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-7f999938245933d1.so --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-959ba3a7ab7a2be3.so --extern graphviz=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-0bde40de32995f14.so --extern rustc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc-cb643e904ecf9227.so --extern byteorder=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbyteorder-ca61dfec7c40c4d4.rlib --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-3e35efb9e5bc7a9a.rlib --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-9866e194db82a141.rlib --extern rustc_const_math=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_const_math-648afcf1a0c2954c.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-c04ded78717d5d67.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-c04ded78717d5d67.rlib -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/backtrace-sys-22398a187b4139a2/out/.libs -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-4a7fffed6b170d5b/out` (exit code: 101)
[00:16:04] error: build failed
[00:16:04] error: build failed
[00:16:04] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:16:04] expected success, got: exit code: 101
[00:16:04] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:16:04] travis_fold:end:stage0-rustc

[00:16:04] travis_time:end:stage0-rustc:start=1524748512074088992,finish=1524749171467326972,duration=659393237980


[00:16:04] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:16:04] Build completed unsuccessfully in 0:11:12
[00:16:04] Makefile:28: recipe for target 'all' failed
[00:16:04] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0f843603
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-04-26T14:40:26Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:47:18]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:47:20] error[E0432]: unresolved import `syntax::abi`
[00:47:20]   --> librustdoc/html/render.rs:57:14
[00:47:20]    |
[00:47:20] 57 | use syntax::{abi, ast};
[00:47:20]    |              ^^^ no `abi` in the root
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]    |
[00:47:20] 68 | use rustc_target::spec::TargetTriple;
[00:47:20] 68 | use rustc_target::spec::TargetTriple;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]   --> librustdoc/clean/mod.rs:23:5
[00:47:20]    |
[00:47:20] 23 | use rustc_target::spec::abi::Abi;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]    |
[00:47:20] 26 | use rustc_target::spec::TargetTriple;
[00:47:20] 26 | use rustc_target::spec::TargetTriple;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]   --> librustdoc/doctree.rs:16:5
[00:47:20] 16 | use rustc_target::spec::abi;
[00:47:20] 16 | use rustc_target::spec::abi;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]   --> librustdoc/html/format.rs:22:5
[00:47:20]    |
[00:47:20] 22 | use rustc_target::spec::abi::Abi;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Maybe a missing `extern crate rustc_target;`?
[00:47:20]   --> librustdoc/visit_ast.rs:16:5
[00:47:20] 16 | use rustc_target::spec::abi;
[00:47:20] 16 | use rustc_target::spec::abi;
[00:47:20]    |     ^^^^^^^^^^^^ Maybe a missing `extern crate rustc_target;`?
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `Abi`
[00:47:20]     --> librustdoc/clean/mod.rs:3732:26
[00:47:20]      |
[00:47:20] 3732 |                     abi: Abi::Rust,
[00:47:20]      |                          ^^^ Use of undeclared type or module `Abi`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `TargetTriple`
[00:47:20]     |
[00:47:20]     |
[00:47:20] 142 |     let host_triple = TargetTriple::from_triple(config::host_triple());
[00:47:20]     |                       ^^^^^^^^^^^^ Use of undeclared type or module `TargetTriple`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `abi`
[00:47:20]    --> librustdoc/doctree.rs:156:14
[00:47:20]     |
[00:47:20] 156 |     pub abi: abi::Abi,
[00:47:20]     |              ^^^ Use of undeclared type or module `abi`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `Abi`
[00:47:20]     --> librustdoc/html/format.rs:1024:13
[00:47:20]      |
[00:47:20] 1024 |             Abi::Rust => Ok(()),
[00:47:20]      |             ^^^ Use of undeclared type or module `Abi`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `abi`
[00:47:20]    --> librustdoc/visit_ast.rs:179:27
[00:47:20]     |
[00:47:20] 179 |                     abi: &abi::Abi,
[00:47:20]     |                           ^^^ Use of undeclared type or module `abi`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `TargetTriple`
[00:47:20]     |
[00:47:20]     |
[00:47:20] 621 |             TargetTriple::TargetPath(PathBuf::from(target))
[00:47:20]     |             ^^^^^^^^^^^^ Use of undeclared type or module `TargetTriple`
[00:47:20] 
[00:47:20] error[E0433]: failed to resolve. Use of undeclared type or module `TargetTriple`
[00:47:20]     |
[00:47:20]     |
[00:47:20] 623 |             TargetTriple::TargetTriple(target)
[00:47:20]     |             ^^^^^^^^^^^^ Use of undeclared type or module `TargetTriple`
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `Abi` in this scope
[00:47:20]     --> librustdoc/clean/mod.rs:1867:14
[00:47:20]      |
[00:47:20] 1867 |     pub abi: Abi,
[00:47:20]      |              ^^^ not found in this scope
[00:47:20] help: possible candidate is found in another module, you can import it into scope
[00:47:20]      |
[00:47:20] 14   | use rustc::ty::layout::Abi;
[00:47:20] 
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `Abi` in this scope
[00:47:20]     --> librustdoc/clean/mod.rs:1888:14
[00:47:20]      |
[00:47:20] 1888 |     pub abi: Abi,
[00:47:20]      |              ^^^ not found in this scope
[00:47:20] help: possible candidate is found in another module, you can import it into scope
[00:47:20]      |
[00:47:20] 14   | use rustc::ty::layout::Abi;
[00:47:20] 
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `Abi` in this scope
[00:47:20]     --> librustdoc/clean/mod.rs:1897:14
[00:47:20]      |
[00:47:20] 1897 |     pub abi: Abi,
[00:47:20]      |              ^^^ not found in this scope
[00:47:20] help: possible candidate is found in another module, you can import it into scope
[00:47:20]      |
[00:47:20] 14   | use rustc::ty::layout::Abi;
[00:47:20] 
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `Abi` in this scope
[00:47:20]     --> librustdoc/clean/mod.rs:3413:14
[00:47:20]      |
[00:47:20] 3413 |     pub abi: Abi,
[00:47:20]      |              ^^^ not found in this scope
[00:47:20] help: possible candidate is found in another module, you can import it into scope
[00:47:20]      |
[00:47:20] 14   | use rustc::ty::layout::Abi;
[00:47:20] 
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `TargetTriple` in this scope
[00:47:20]     |
[00:47:20]     |
[00:47:20] 124 |                 triple: Option<TargetTriple>,
[00:47:20] 
[00:47:20] 
[00:47:20] error[E0412]: cannot find type `Abi` in this scope
[00:47:20]   --> librustdoc/html/format.rs:52:25
[00:47:20]    |
[00:47:20] 52 | pub struct AbiSpace(pub Abi);
[00:47:20]    |                         ^^^ not found in this scope
[00:47:20] help: possible candidate is found in another module, you can import it into scope
[00:47:20]    |
[00:47:20] 18 | use rustc::ty::layout::Abi;
[00:47:20] 
[00:47:20] 
[00:47:21] error: unused import: `rustc_target::spec::TargetTriple`
[00:47:21]    |
[00:47:21] 68 | use rustc_target::spec::TargetTriple;
[00:47:21]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:47:21]    |
[00:47:21]    |
[00:47:21]    = note: `-D unused-imports` implied by `-D warnings`
[00:47:21] 
[00:47:21] error: unused import: `rustc_target::spec::abi::Abi`
[00:47:21]   --> librustdoc/clean/mod.rs:23:5
[00:47:21]    |
[00:47:21] 23 | use rustc_target::spec::abi::Abi;
[00:47:21] 
[00:47:21] 
[00:47:21] error: unused import: `rustc_target::spec::TargetTriple`
[00:47:21]    |
[00:47:21] 26 | use rustc_target::spec::TargetTriple;
[00:47:21]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:47:21] 
[00:47:21] 
[00:47:21] error: unused import: `rustc_target::spec::abi`
[00:47:21]   --> librustdoc/doctree.rs:16:5
[00:47:21] 16 | use rustc_target::spec::abi;
[00:47:21]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[00:47:21] 
[00:47:21] 
[00:47:21] error: unused import: `rustc_target::spec::abi::Abi`
[00:47:21]   --> librustdoc/html/format.rs:22:5
[00:47:21]    |
[00:47:21] 22 | use rustc_target::spec::abi::Abi;
[00:47:21] 
[00:47:21] 
[00:47:21] error: unused import: `rustc_target::spec::abi`
[00:47:21]   --> librustdoc/visit_ast.rs:16:5
[00:47:21] 16 | use rustc_target::spec::abi;
[00:47:21]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[00:47:21] 
7:start=1524753621087041643,finish=1524753621095849794,duration=8808151

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-04-26T15:54:21Z

@bors r=nikomatsakis

bors · 2018-04-26T15:54:22Z

📌 Commit a131c51 has been approved by nikomatsakis

bors · 2018-04-26T16:00:55Z

⌛ Testing commit a131c51 with merge 949010d...

Rename rustc_back to rustc_target and move ABI code to it. Fixes #45226.

bors · 2018-04-26T18:24:51Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 949010d to master...

kennytm-githubbot · 2018-04-26T18:26:21Z

📣 Toolstate changed by #50228!

Tested on commit 949010d.
Direct link to PR: #50228

💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk).
💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk).
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb).

@Manishearth

Tested on commit rust-lang/rust@949010d. Direct link to PR: <rust-lang/rust#50228> 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk). 💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk). 💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb). 💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb).

rust-highfive assigned estebank Apr 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2018

rust-highfive assigned nikomatsakis and unassigned estebank Apr 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2018

irinagpopa added 7 commits April 26, 2018 16:39

rustc_back: move LinkerFlavor, PanicStrategy, and RelroLevel to target.

6f03b80

Rename rustc_back::target to rustc_target::spec.

38e9640

rustc_target: move in type definitions from ty::layout.

bdcd082

rustc_target: move in type definitions from rustc_trans::abi.

3bd7efa

rustc_target: move LayoutOf's type parameter to an associated type.

7a51476

rustc_target: move for_variant and field TyLayout methods to a trait.

c45dda9

rustc_trans: generalize cabi_* to any context type.

fb15d44

rustc_target: move in cabi_* from rustc_trans.

030244c

irinagpopa added 2 commits April 26, 2018 17:49

rustc_target: move in syntax::abi and flip dependency.

04fa0e7

Fixed tidy errors.

a131c51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2018

bors added a commit that referenced this pull request Apr 26, 2018

Auto merge of #50228 - irinagpopa:backstory-v2, r=nikomatsakis

949010d

Rename rustc_back to rustc_target and move ABI code to it. Fixes #45226.

bors merged commit a131c51 into rust-lang:master Apr 26, 2018

This was referenced Apr 26, 2018

Remove some unused code #50198

Merged

Compile LLVM with Clang on release builders #50200

Merged

topecongiro mentioned this pull request Apr 28, 2018

Add rustc-ap-rustc_target to dependencies rust-lang/rustfmt#2658

Closed

irinagpopa deleted the backstory-v2 branch May 2, 2018 10:49

eddyb mentioned this pull request Jul 13, 2018

Refactor rustc_trans::abi not to use LLVM #39617

Closed

lqd mentioned this pull request Jul 17, 2019

ICE: Generic type alias to invalid type crashes during type check on latest stable #62742

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename rustc_back to rustc_target and move ABI code to it. #50228

Rename rustc_back to rustc_target and move ABI code to it. #50228

irinagpopa commented Apr 25, 2018 •

edited

Loading

rust-highfive commented Apr 25, 2018

eddyb commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

rust-highfive commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

eddyb commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

rust-highfive commented Apr 26, 2018

rust-highfive commented Apr 26, 2018

eddyb commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

kennytm-githubbot commented Apr 26, 2018

Rename rustc_back to rustc_target and move ABI code to it. #50228

Rename rustc_back to rustc_target and move ABI code to it. #50228

Conversation

irinagpopa commented Apr 25, 2018 • edited Loading

rust-highfive commented Apr 25, 2018

eddyb commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

rust-highfive commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

eddyb commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

rust-highfive commented Apr 26, 2018

rust-highfive commented Apr 26, 2018

eddyb commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

bors commented Apr 26, 2018

kennytm-githubbot commented Apr 26, 2018

irinagpopa commented Apr 25, 2018 •

edited

Loading