Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for #[repr(align=x)] #50317

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Improve error message for #[repr(align=x)] #50317

merged 2 commits into from
Apr 30, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 29, 2018

Before:

error[E0552]: unrecognized representation hint
 --> src/main.rs:1:8
  |
1 | #[repr(align="8")]
  |        ^^^^^^^^^

After:

error[E0693]: incorrect `repr(align)` attribute format
 --> src/main.rs:1:8
  |
2 | #[repr(align="8")]
  |        ^^^^^^^^^ help: use parentheses instead: `align(8)`

Fixes #50314.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2018
@varkor
Copy link
Member Author

varkor commented Apr 29, 2018

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned nikomatsakis Apr 29, 2018
@nagisa
Copy link
Member

nagisa commented Apr 29, 2018

Lovely!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2018

📌 Commit 35fe299 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2018
@bors
Copy link
Contributor

bors commented Apr 29, 2018

⌛ Testing commit 35fe299 with merge 774a6a3...

bors added a commit that referenced this pull request Apr 29, 2018
@bors
Auto merge of #50317 - varkor:repr-align-assign, r=nagisa
774a6a3 
Improve error message for #[repr(align=x)]

Before:
```
error[E0552]: unrecognized representation hint
 --> src/main.rs:1:8
  |
1 | #[repr(align="8")]
  |        ^^^^^^^^^
```
After:
```
error[E0693]: incorrect `repr(align)` attribute format
 --> src/main.rs:1:8
  |
2 | #[repr(align="8")]
  |        ^^^^^^^^^ help: use parentheses instead: `align(8)`
```

Fixes #50314.
@bors
Copy link
Contributor

bors commented Apr 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nagisa
Pushing 774a6a3 to master...

@bors bors merged commit 35fe299 into rust-lang:master Apr 30, 2018
@bors bors mentioned this pull request Apr 30, 2018
Merged
@varkor varkor deleted the repr-align-assign branch April 30, 2018 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varkor @rust-highfive @nagisa @bors @nikomatsakis