Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct initial field alignment for repr(C)/repr(int) #50354

Merged
merged 3 commits into from
May 2, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 30, 2018

Fixes #50098 following #50098 (comment).

(I wasn't sure which kind of test was best suited here — I picked run-pass simply because that was convenient, but if codegen is more appropriate, let me know and I'll change it.)

r? @eddyb

@varkor
Copy link
Member Author

varkor commented Apr 30, 2018

r? @eddyb (@rust-highfive is being negligent...)

@Gankra
Copy link
Contributor

Gankra commented May 1, 2018

Could you dupe the test for repr(u8) as well?

@eddyb
Copy link
Member

eddyb commented May 1, 2018

@varkor You could also add/modify a test in ui/print_type_sizes or those added in #46123.

@varkor varkor force-pushed the initial-field-alignment-c-int branch from 45b2c1f to 4da1f71 Compare May 1, 2018 19:11
@varkor
Copy link
Member Author

varkor commented May 1, 2018

@gankro: good point!

@eddyb: ah, perfect, that's just what I was looking for.

@eddyb
Copy link
Member

eddyb commented May 1, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2018

📌 Commit 2d0d73e has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 1, 2018
@bors
Copy link
Contributor

bors commented May 2, 2018

⌛ Testing commit 2d0d73e with merge 3eadd75...

bors added a commit that referenced this pull request May 2, 2018
Correct initial field alignment for repr(C)/repr(int)

Fixes #50098 following #50098 (comment).

(I wasn't sure which kind of test was best suited here — I picked run-pass simply because that was convenient, but if codegen is more appropriate, let me know and I'll change it.)

r? @eddyb
@bors
Copy link
Contributor

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 3eadd75 to master...

@bors bors merged commit 2d0d73e into rust-lang:master May 2, 2018
@varkor varkor deleted the initial-field-alignment-c-int branch May 2, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants