Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover tab in libtest outputs #50387

Merged
merged 1 commit into from
May 18, 2018
Merged

Remove leftover tab in libtest outputs #50387

merged 1 commit into from
May 18, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented May 2, 2018 •
edited
Loading

This removes some tabs that were present in the output of libtest.

Related #19299
Closes #50362

@rust-highfive
Copy link
Collaborator

r? @bluss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2018
@phansch
Copy link
Member Author

phansch commented May 2, 2018

Thinking about this some more, I could imagine that some IDEs or editors expect the tab to be in the test output, since it has been around for a long time?

@nikomatsakis
Copy link
Contributor

Maybe, but I sort of doubt it. That'd be some pretty careful parsing of the output, and we don't really consider this output to be stable.

@TimNN
Copy link
Contributor

TimNN commented May 8, 2018

@bluss or someone else from @rust-lang/dev-tools, could you please review this PR?

@pietroalbini pietroalbini added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 14, 2018
@pietroalbini
Copy link
Member

Ping from triage! This PR needs a review, can @bluss or someone else from @rust-lang/libs review this?

@pietroalbini pietroalbini added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 14, 2018
@alexcrichton
Copy link
Member

@bors: r+

Thanks @phansch!

@bors
Copy link
Contributor

bors commented May 14, 2018

📌 Commit 4f2cfb5 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 14, 2018
@kennytm
Rollup merge of rust-lang#50387 - phansch:remove_leftover_tab, r=alex…
3acea17 
…crichton

Remove leftover tab in libtest outputs

This removes some tabs that were present in the output of libtest.

Related rust-lang#19299
Closes rust-lang#50362
@kennytm kennytm mentioned this pull request May 14, 2018
Closed
ehuss added a commit to ehuss/cargo that referenced this pull request May 15, 2018
@ehuss
Ignore <tab> in libtest output.
1a715aa 
rust-lang/rust#50387 is changing the output from libtest which affected a few Cargo tests.
@ehuss ehuss mentioned this pull request May 15, 2018
Merged
bors added a commit to rust-lang/cargo that referenced this pull request May 15, 2018
@bors
Auto merge of #5535 - ehuss:ignore-test-tab, r=alexcrichton
d601e9d 
Ignore <tab> in libtest output.

rust-lang/rust#50387 is changing the output from libtest which affected a few Cargo tests.
@kennytm kennytm mentioned this pull request May 15, 2018
Merged
@kennytm
Copy link
Member

kennytm commented May 15, 2018

@bors r-

Blocked by #50696.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2018
@kennytm kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 15, 2018
ehuss added a commit to ehuss/rust that referenced this pull request May 15, 2018
@ehuss
Update Cargo
b5817dd 
Unblocking PRs:
- rust-lang/cargo#5535 - Ignore <tab> in libtest output. (unblocks rust-lang#50387)
- rust-lang/cargo#5537 - Remove -Zno-trans test. (unblocks rust-lang#50615)
- rust-lang/cargo#5540 - Fix tests when CARGO_TARGET_DIR is set. (unblocks self)

Regression fixes:
- rust-lang/cargo#5503 - cargo rustc broken for tests in project with bins
- rust-lang/cargo#5520 - (rust-lang#50640) shared proc-macro dependency built incorrectly

Changes:
- rust-lang/cargo#5527 - Point Source Replacement to the Overriding Dependencies section
- rust-lang/cargo#5533 - Detail how to run locally-built nightly cargo
- rust-lang/cargo#5522 - Add option to set user-agent
- rust-lang/cargo#5519 - NFC: fix a couple of typos, found by codespell.
- rust-lang/cargo#5513 - Fix `panic` for binaries built during tests.
- rust-lang/cargo#5512 - simplify build_requirements
- rust-lang/cargo#5301 - Add --build-plan for 'cargo build'
- rust-lang/cargo#5460 - Be more conservative about which files are linked to the output dir.
- rust-lang/cargo#5509 - Use the new stable
- rust-lang/cargo#5507 - Does not print seconds fraction with minutes
- rust-lang/cargo#5498 - Bump to 0.29.0
- rust-lang/cargo#5497 - Mention +nightly in ARCHITECTURE.md
kennytm added a commit to kennytm/rust that referenced this pull request May 15, 2018
@kennytm
Rollup merge of rust-lang#50696 - ehuss:cargo-update, r=alexcrichton
b2200b4 
Update Cargo

Unblocking PRs:
- rust-lang/cargo#5535 - Ignore <tab> in libtest output. (unblocks rust-lang#50387)
- rust-lang/cargo#5537 - Remove -Zno-trans test. (unblocks rust-lang#50615)
- rust-lang/cargo#5540 - Fix tests when CARGO_TARGET_DIR is set. (unblocks self)

Regression fixes:
- rust-lang/cargo#5503 - cargo rustc broken for tests in project with bins
- rust-lang/cargo#5520 - (rust-lang#50640) shared proc-macro dependency built incorrectly

Changes:
- rust-lang/cargo#5527 - Point Source Replacement to the Overriding Dependencies section
- rust-lang/cargo#5533 - Detail how to run locally-built nightly cargo
- rust-lang/cargo#5522 - Add option to set user-agent
- rust-lang/cargo#5519 - NFC: fix a couple of typos, found by codespell.
- rust-lang/cargo#5513 - Fix `panic` for binaries built during tests.
- rust-lang/cargo#5512 - simplify build_requirements
- rust-lang/cargo#5301 - Add --build-plan for 'cargo build'
- rust-lang/cargo#5460 - Be more conservative about which files are linked to the output dir.
- rust-lang/cargo#5509 - Use the new stable
- rust-lang/cargo#5507 - Does not print seconds fraction with minutes
- rust-lang/cargo#5498 - Bump to 0.29.0
- rust-lang/cargo#5497 - Mention +nightly in ARCHITECTURE.md
ehuss added a commit to ehuss/rust that referenced this pull request May 16, 2018
@ehuss
Update Cargo
a233268 
Unblocking PRs:
- rust-lang/cargo#5535 - Ignore <tab> in libtest output. (unblocks rust-lang#50387)
- rust-lang/cargo#5537 - Remove -Zno-trans test. (unblocks rust-lang#50615)
- rust-lang/cargo#5540 - Fix tests when CARGO_TARGET_DIR is set. (unblocks self)

Regression fixes:
- rust-lang/cargo#5503 - cargo rustc broken for tests in project with bins
- rust-lang/cargo#5520 - (rust-lang#50640) shared proc-macro dependency built incorrectly

Changes:
- rust-lang/cargo#5527 - Point Source Replacement to the Overriding Dependencies section
- rust-lang/cargo#5533 - Detail how to run locally-built nightly cargo
- rust-lang/cargo#5522 - Add option to set user-agent
- rust-lang/cargo#5519 - NFC: fix a couple of typos, found by codespell.
- rust-lang/cargo#5513 - Fix `panic` for binaries built during tests.
- rust-lang/cargo#5512 - simplify build_requirements
- rust-lang/cargo#5301 - Add --build-plan for 'cargo build'
- rust-lang/cargo#5460 - Be more conservative about which files are linked to the output dir.
- rust-lang/cargo#5509 - Use the new stable
- rust-lang/cargo#5507 - Does not print seconds fraction with minutes
- rust-lang/cargo#5498 - Bump to 0.29.0
- rust-lang/cargo#5497 - Mention +nightly in ARCHITECTURE.md
bors added a commit that referenced this pull request May 16, 2018
@bors
Auto merge of #50696 - ehuss:cargo-update, r=alexcrichton
4208bd5 
Update Cargo

Unblocking PRs:
- rust-lang/cargo#5535 - Ignore tab in libtest output. (unblocks #50387)
- rust-lang/cargo#5537 - Remove -Zno-trans test. (unblocks #50615)
- rust-lang/cargo#5540 - Fix tests when CARGO_TARGET_DIR is set. (unblocks self)

Regression fixes:
- rust-lang/cargo#5503 - cargo rustc broken for tests in project with bins
- rust-lang/cargo#5520 - shared proc-macro dependency built incorrectly

Changes:
- rust-lang/cargo#5527 - Point Source Replacement to the Overriding Dependencies section
- rust-lang/cargo#5533 - Detail how to run locally-built nightly cargo
- rust-lang/cargo#5522 - Add option to set user-agent
- rust-lang/cargo#5519 - NFC: fix a couple of typos, found by codespell.
- rust-lang/cargo#5513 - Fix `panic` for binaries built during tests.
- rust-lang/cargo#5512 - simplify build_requirements
- rust-lang/cargo#5301 - Add --build-plan for 'cargo build'
- rust-lang/cargo#5460 - Be more conservative about which files are linked to the output dir.
- rust-lang/cargo#5509 - Use the new stable
- rust-lang/cargo#5507 - Does not print seconds fraction with minutes
- rust-lang/cargo#5498 - Bump to 0.29.0
- rust-lang/cargo#5497 - Mention +nightly in ARCHITECTURE.md

The PR fixes #50640.
@phansch
Copy link
Member Author

phansch commented May 17, 2018

With #50696 merged, I believe this should be ready now.

@kennytm
Copy link
Member

kennytm commented May 17, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented May 17, 2018

📌 Commit 4f2cfb5 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels May 17, 2018
@kennytm
Copy link
Member

kennytm commented May 17, 2018

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 17, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#50387 - phansch:remove_leftover_tab, r=alex…
6e95b87 
…crichton

Remove leftover tab in libtest outputs

This removes some tabs that were present in the output of libtest.

Related rust-lang#19299
Closes rust-lang#50362
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 17, 2018
Merged
bors added a commit that referenced this pull request May 18, 2018
@bors
Auto merge of #50847 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
dfc07a4 
Rollup of 10 pull requests

Successful merges:

 - #50387 (Remove leftover tab in libtest outputs)
 - #50553 (Add Option::xor method)
 - #50610 (Improve format string errors)
 - #50649 (Tweak `nearest_common_ancestor()`.)
 - #50790 (Fix grammar documentation wrt Unicode identifiers)
 - #50791 (Fix null exclusions in grammar docs)
 - #50806 (Add `bless` x.py subcommand for easy ui test replacement)
 - #50818 (Speed up `opt_normalize_projection_type`)
 - #50837 (Revert #49767)
 - #50839 (Make sure people know the book is free oline)

Failed merges:
@bors bors merged commit 4f2cfb5 into rust-lang:master May 18, 2018
@phansch phansch deleted the remove_leftover_tab branch May 18, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bluss bluss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@phansch @rust-highfive @nikomatsakis @TimNN @pietroalbini @alexcrichton @bors @kennytm @bluss