Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement FromStr for PathBuf" #50401

Merged
merged 1 commit into from
May 3, 2018

Conversation

alexcrichton
Copy link
Member

This reverts commit 05a9acc.

The libs team was discussing #44431 today and the changes originally added in #48292 and the conclusion was that we'd like to revert this for now until ! is stable. This'll provide us maximal flexibility to tweak the error type here in the future, and it looks like ! is close-ish to stabilization so hopefully this won't be delayed for too long.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2018
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2018
@alexcrichton
Copy link
Member Author

r? @sfackler

@rust-highfive rust-highfive assigned sfackler and unassigned aturon May 2, 2018
@sfackler
Copy link
Member

sfackler commented May 2, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2018

📌 Commit f684147 has been approved by sfackler

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 2, 2018
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 3, 2018
bors added a commit that referenced this pull request May 3, 2018
[beta] Revert "Implement FromStr for PathBuf"

This is a backport of #50401
kennytm added a commit to kennytm/rust that referenced this pull request May 3, 2018
…r=sfackler

Revert "Implement FromStr for PathBuf"

This reverts commit 05a9acc.

The libs team was discussing rust-lang#44431 today and the changes originally added in rust-lang#48292 and the conclusion was that we'd like to revert this for now until `!` is stable. This'll provide us maximal flexibility to tweak the error type here in the future, and it looks like `!` is close-ish to stabilization so hopefully this won't be delayed for too long.
bors added a commit that referenced this pull request May 3, 2018
Rollup of 12 pull requests

Successful merges:

 - #50302 (Add query search order check)
 - #50320 (Fix invalid path generation in rustdoc search)
 - #50349 (Rename "show type declaration" to "show declaration")
 - #50360 (Clarify wordings of the `unstable_name_collision` lint.)
 - #50365 (Use two vectors in nearest_common_ancestor.)
 - #50393 (Allow unaligned reads in constants)
 - #50401 (Revert "Implement FromStr for PathBuf")
 - #50406 (Forbid constructing empty identifiers from concat_idents)
 - #50407 (Always inline simple BytePos and CharPos methods.)
 - #50416 (check if the token is a lifetime before parsing)
 - #50417 (Update Cargo)
 - #50421 (Fix ICE when using a..=b in a closure.)

Failed merges:
@bors bors merged commit f684147 into rust-lang:master May 3, 2018
@alexcrichton alexcrichton deleted the remove-path-from-str branch May 10, 2018 19:19
SimonSapin added a commit to SimonSapin/rust that referenced this pull request Oct 17, 2018
Initially landed in rust-lang#48292
and reverted in rust-lang#50401.
This time, use `std::string::ParseError` as suggested in
rust-lang#44431 (comment)
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
Implement FromStr for PathBuf

Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018
Implement FromStr for PathBuf

Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
ischeinkman pushed a commit to ischeinkman/libnx-rs-std that referenced this pull request Dec 20, 2018
Initially landed in rust-lang#48292
and reverted in rust-lang#50401.
This time, use `std::string::ParseError` as suggested in
rust-lang#44431 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants