-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix self referential impl Trait substitutions #50694
Fix self referential impl Trait substitutions #50694
Conversation
A high impact bug because a lot of common traits use a `Self` substitution by default. Should be backported to beta. There was a check for this which wasn't catching all cases, it was made more robust. Fixes rust-lang#49376 Fixes rust-lang#50626 r? @petrochenkov
Thanks! |
📌 Commit 56bc4c2 has been approved by |
…r=petrochenkov Fix self referential impl Trait substitutions A high impact bug because a lot of common traits use a `Self` substitution by default. Should be backported to beta. There was a check for this which wasn't catching all cases, it was made more robust. Fixes #49376 Fixes #50626 r? @petrochenkov
☀️ Test successful - status-appveyor, status-travis |
@leodasvacas proposed to backport this in #50737. @rust-lang/compiler? |
Justification for backport: Previously |
[beta] Process backports Merged on master: * #50648: Fix volatile_store and nontemporal_store * #50735: rustc: don't trip an assertion for enums with present but uninhabited variants. * #50693: typeck: Save the index of private fields * #50748: Update stdsimd module * #50694: Fix self referential impl Trait substitutions r? @alexcrichton
A high impact bug because a lot of common traits use a
Self
substitution by default. Should be backported to beta.There was a check for this which wasn't catching all cases, it was made more robust.
Fixes #49376
Fixes #50626
r? @petrochenkov