Add command line lint manipulation in rustdoc #51732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
ping from triage @QuietMisdreavus will you have time to review this PR in the near future? |
| @@ -213,7 +217,7 @@ pub fn run_core(search_paths: SearchPaths, | |||
| } else { | |||
| vec![] | |||
| }, | |||
| lint_cap: Some(lint::Forbid), | |||
| lint_cap: Some(lint_cap.unwrap_or_else(|| lint::Forbid)), | |||
There was a problem hiding this comment.
You can leave this as None if you're going to default it to Forbid anyway; rustc will do this unwrap itself later on.
There was a problem hiding this comment.
No, I did at first but didn't get the expected result.
There was a problem hiding this comment.
Huh, weird, I didn't realize it was unwrapped anywhere other than where it was used.
src/librustdoc/lib.rs
Outdated
| "cap-lints", | ||
| "Set the most restrictive lint level. \ | ||
| More restrictive lints are capped at this \ | ||
| level. Byt default, it is at `forbid` level.", |
GuillaumeGomez
force-pushed
the
cmd-line-lint-rustdoc
branch
from
77dd609
to
e221be8
Compare
|
r=me pending travis |
|
@bors: r=QuietMisdreavus |
|
📌 Commit e221be8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 5, 2018
…isdreavus Add command line lint manipulation in rustdoc Fixes #50082. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jul 6, 2018
bors
added a commit
that referenced
this pull request
Jul 20, 2018
stabilize lint handling in rustdoc When #51732 added CLI flags to manipulate lints in rustdoc, they were added as unstable flags. This made sense as they were new additions, but since they mirrored the flags that rustc has, it's worth considering them to not need an unstable period. Stabilizing them also provides the opportunity for a critical fix: allowing Cargo to pass `--cap-lints allow` when documenting dependencies, the same as when it compiles them. r? @rust-lang/rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50082.
r? @QuietMisdreavus