Remove unwrap_shared_mutable_state #5176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Mar 1, 2013
…atsakis r? This fixes the current [random failures](http://buildbot.rust-lang.org/builders/auto-linux/builds/291/steps/test/logs/stdio) on the bots and closes #4436 by removing `unwrap_shared_mutable_state` and the code that depends on it. The result is that ARC-like things will not be unwrappable. This feature is complex and is not used outside of test cases. Note that there is not consensus to remove it. (second commit)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 22, 2021
Improve `map_entry` suggestion fixes: rust-lang#5176 fixes: rust-lang#4674 fixes: rust-lang#4664 fixes: rust-lang#1450 Still need to handle the value returned by `insert` correctly. changelog: Improve `map_entry` suggestion. Will now suggest `or_insert`, `insert_with` or `match _.entry(_)` as appopriate. changelog: Fix `map_entry` false positives where the entry api can't be used. e.g. when the map is used for multiple things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?
This fixes the current random failures on the bots and closes #4436 by removing
unwrap_shared_mutable_stateand the code that depends on it. The result is that ARC-like things will not be unwrappable. This feature is complex and is not used outside of test cases.Note that there is not consensus to remove it.
(second commit)