Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny bare trait objects in src/liballoc #52223

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Deny bare trait objects in src/liballoc #52223

merged 3 commits into from
Jul 11, 2018

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Jul 10, 2018

Enforce #![deny(bare_trait_objects)] in src/liballoc.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
Testing alloc stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:57:02]    Compiling libc v0.2.42
[00:57:03]    Compiling rand v0.4.2
[00:57:05]    Compiling alloc v0.0.0 (file:///checkout/src/liballoc)
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:34:32
[00:57:06]    |
[00:57:06] 34 |     let a = Box::new(8) as Box<Any>;
[00:57:06]    |                                ^^^ help: use `dyn`: `dyn Any`
[00:57:06] note: lint level defined here
[00:57:06]   --> liballoc/lib.rs:75:9
[00:57:06]    |
[00:57:06]    |
[00:57:06] 75 | #![deny(bare_trait_objects)]
[00:57:06] 
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:35:35
[00:57:06]    |
[00:57:06] 35 |     let b = Box::new(Test) as Box<Any>;
[00:57:06]    |                                   ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:50:32
[00:57:06]    |
[00:57:06] 50 |     let a = Box::new(8) as Box<Any>;
[00:57:06]    |                                ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:51:35
[00:57:06]    |
[00:57:06] 51 |     let b = Box::new(Test) as Box<Any>;
[00:57:06]    |                                   ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:59:32
[00:57:06]    |
[00:57:06] 59 |     let a = Box::new(8) as Box<Any>;
[00:57:06]    |                                ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:60:35
[00:57:06]    |
[00:57:06] 60 |     let b = Box::new(Test) as Box<Any>;
[00:57:06]    |                                   ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:68:24
[00:57:06]    |
[00:57:06] 68 |     let a = &EIGHT as &Any;
[00:57:06]    |                        ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]   --> liballoc/boxed_test.rs:69:23
[00:57:06]    |
[00:57:06] 69 |     let b = &TEST as &Any;
[00:57:06]    |                       ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]    --> liballoc/boxed_test.rs:113:16
[00:57:06]     |
[00:57:06] 113 |     let x: Box<Foo> = Box::new(Bar(17));
[00:57:06]     |                ^^^ help: use `dyn`: `dyn Foo`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]    --> liballoc/boxed_test.rs:118:20
[00:57:06]     |
[00:57:06] 118 |         let y: Box<Foo> = Box::from_raw(p);
[00:57:06]     |                    ^^^ help: use `dyn`: `dyn Foo`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1577 |         let arc: Arc<Display> = Arc::new(123);
[00:57:06]      |                      ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1882 |         let b: Box<Display> = box 123;
[00:57:06]      |                    ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1883 |         let r: Arc<Display> = Arc::from(b);
[00:57:06]      |                    ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1892 |         let b: Box<Debug> = box ();
[00:57:06]      |                    ^^^^^ help: use `dyn`: `dyn Debug`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1893 |         let r: Arc<Debug> = Arc::from(b);
[00:57:06]      |                    ^^^^^ help: use `dyn`: `dyn Debug`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1910 |         let r1: Arc<Any + Send + Sync> = Arc::new(i32::max_value());
[00:57:06]      |                     ^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Any + Send + Sync`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]      |
[00:57:06]      |
[00:57:06] 1911 |         let r2: Arc<Any + Send + Sync> = Arc::new("abc");
[00:57:06]      |                     ^^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn Any + Send + Sync`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1557:20
[00:57:06]      |
[00:57:06] 1557 |         let rc: Rc<Display> = Rc::new(123);
[00:57:06]      |                    ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1758:20
[00:57:06]      |
[00:57:06] 1758 |         let b: Box<Display> = box 123;
[00:57:06]      |                    ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1759:19
[00:57:06]      |
[00:57:06] 1759 |         let r: Rc<Display> = Rc::from(b);
[00:57:06]      |                   ^^^^^^^ help: use `dyn`: `dyn Display`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1768:20
[00:57:06]      |
[00:57:06] 1768 |         let b: Box<Debug> = box ();
[00:57:06]      |                    ^^^^^ help: use `dyn`: `dyn Debug`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1769:19
[00:57:06]      |
[00:57:06] 1769 |         let r: Rc<Debug> = Rc::from(b);
[00:57:06]      |                   ^^^^^ help: use `dyn`: `dyn Debug`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1786:20
[00:57:06]      |
[00:57:06] 1786 |         let r1: Rc<Any> = Rc::new(i32::max_value());
[00:57:06]      |                    ^^^ help: use `dyn`: `dyn Any`
[00:57:06] 
[00:57:06] error: trait objects without an explicit `dyn` are deprecated
[00:57:06]     --> liballoc/rc.rs:1787:20
[00:57:06]      |
[00:57:06] 1787 |         let r2: Rc<Any> = Rc::new("abc");
[00:57:06]      |                    ^^^ help: use `dyn`: `dyn Any`
[00:57:09] error: aborting due to 24 previous errors
[00:57:09] 
[00:57:09] error: Could not compile `alloc`.
[00:57:09] warning: build failed, waiting for other jobs to finish...
[00:57:09] warning: build failed, waiting for other jobs to finish...
[00:57:40] error: build failed
[00:57:40] 
[00:57:40] 
[00:57:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--" "--quiet"
[00:57:40] 
[00:57:40] 
[00:57:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[00:57:40] Build completed unsuccessfully in 0:15:51
[00:57:40] Build completed unsuccessfully in 0:15:51
[00:57:40] Makefile:58: recipe for target 'check' failed
[00:57:40] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2114ddeb
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0cf86e0d:start=1531252893580039068,finish=1531252893587372399,duration=7333331
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c9f42cb
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a67c1ed
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ljedrz
Copy link
Contributor Author

ljedrz commented Jul 10, 2018

I see that I made some branch-switching error here; I'll fix it shortly.

@cramertj
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 11, 2018

📌 Commit 217f8fb has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 11, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52223 - ljedrz:dyn_liballoc, r=cramertj
d096f6a 
Deny bare trait objects in in src/liballoc

Enforce #![deny(bare_trait_objects)] in src/liballoc.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 11, 2018
Merged
bors added a commit that referenced this pull request Jul 11, 2018
@bors
Auto merge of #52268 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
704af2d 
Rollup of 14 pull requests

Successful merges:

 - #51614 (Correct suggestion for println)
 - #51952 ( hygiene: Decouple transparencies from expansion IDs)
 - #52193 (step_by: leave time of item skip unspecified)
 - #52207 (improve error message shown for unsafe operations)
 - #52223 (Deny bare trait objects in in src/liballoc)
 - #52224 (Deny bare trait objects in in src/libsyntax)
 - #52239 (Remove sync::Once::call_once 'static bound)
 - #52247 (Deny bare trait objects in in src/librustc)
 - #52248 (Deny bare trait objects in in src/librustc_allocator)
 - #52252 (Deny bare trait objects in in src/librustc_codegen_llvm)
 - #52253 (Deny bare trait objects in in src/librustc_data_structures)
 - #52254 (Deny bare trait objects in in src/librustc_metadata)
 - #52261 (Deny bare trait objects in in src/libpanic_unwind)
 - #52265 (Deny bare trait objects in in src/librustc_codegen_utils)

Failed merges:

r? @ghost
@bors bors merged commit 217f8fb into rust-lang:master Jul 11, 2018
@ljedrz ljedrz deleted the dyn_liballoc branch July 11, 2018 22:12
@ljedrz ljedrz changed the title Deny bare trait objects in in src/liballoc Deny bare trait objects in src/liballoc Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljedrz @rust-highfive @cramertj @bors