Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete armv5te vars from the dist-various-1 Dockerfile #52561

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Remove obsolete armv5te vars from the dist-various-1 Dockerfile #52561

merged 1 commit into from
Jul 25, 2018

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Jul 20, 2018

The related cc issue is closed and its changes are in force.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2018
@TimNN
Copy link
Contributor

TimNN commented Jul 24, 2018

Ping from triage, @aturon, this PR requires your review.

@aturon
Copy link
Member

aturon commented Jul 24, 2018

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Jul 24, 2018
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 24, 2018

📌 Commit 35a3d6f has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2018
@bors
Copy link
Contributor

bors commented Jul 25, 2018

⌛ Testing commit 35a3d6f with merge d09ac8cbfdf3ce92767b70ae1e753e29793acdff...

@bors
Copy link
Contributor

bors commented Jul 25, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2018
@rust-highfive
Copy link
Collaborator

The job armhf-gnu of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:10:56] test [run-pass] run-pass/rvalue-static-promotion.rs ... ok
[01:10:57] test [run-pass] run-pass/rfc1857-drop-order.rs ... ok
[01:10:58] test [run-pass] run-pass/running-with-no-runtime.rs ... ok

Broadcast message from root@travis-job-8f2aec15-00ad-46bf-b0ca-6e3c5b5c5689
 (unknown) at 3:42 ...
The system is going down for power off NOW!

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 143.
travis_time:start:054d4a4f
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ljedrz
Copy link
Contributor Author

ljedrz commented Jul 25, 2018

The system is going down for power off NOW!

Is this spurious or did my change just shut down the test chamber 😆?

@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2018
@bors
Copy link
Contributor

bors commented Jul 25, 2018

⌛ Testing commit 35a3d6f with merge fefe816...

bors added a commit that referenced this pull request Jul 25, 2018
@bors
Auto merge of #52561 - ljedrz:fixme_cc_271, r=alexcrichton
fefe816 
Remove obsolete armv5te vars from the dist-various-1 Dockerfile

The [related cc issue](rust-lang/cc-rs#271) is closed and its changes are in force.
@bors
Copy link
Contributor

bors commented Jul 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing fefe816 to master...

@bors bors merged commit 35a3d6f into rust-lang:master Jul 25, 2018
@ljedrz ljedrz deleted the fixme_cc_271 branch July 25, 2018 11:53
@pnkfelix pnkfelix mentioned this pull request Oct 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ljedrz @rust-highfive @TimNN @aturon @alexcrichton @bors