Format linker args in a way that works for gcc and ld

[alecmocatta]

Pass multiple linker arguments rather than concatenate with commas (fixes #52634).

-l library -> -llibrary to work with apple's ld.

To build with apple's ld I'm currently also passing -C link-args="-arch x86_64 -macosx_version_min 10.13.0". I'll try and understand the latter flag better before PRing that.

This PR currently works for me. Hopefully CI will pick up any grievous ramifications in other toolchains?

Thanks to @alexcrichton for the pointer to the relevant code!

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:56] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:56] tidy error: /checkout/src/librustc_codegen_llvm/back/linker.rs:222: line longer than 100 chars
[00:03:57] some tidy checks failed
[00:03:57] 
[00:03:57] 
[00:03:57] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:57] 
[00:03:57] 
[00:03:57] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:57] Build completed unsuccessfully in 0:00:54
[00:03:57] Build completed unsuccessfully in 0:00:54
[00:03:57] Makefile:79: recipe for target 'tidy' failed
[00:03:57] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:029be766
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:028d7d8e:start=1532391710808549555,finish=1532391710814522356,duration=5972801
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04c0695a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:3a2a2d84
travis_time:start:3a2a2d84
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0eb648a1
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[alexcrichton]

@bors r+

Thanks!

[bors]

📌 Commit 296a179 has been approved by alexcrichton

[RalfJung]

This PR currently works for me. Hopefully CI will pick up any grievous ramifications in other toolchains?

Of course, since this doesn't change CI, if someone else hopes for the same thing again later it might break again for you. :/ I appreciate it is hard to test for these things though. But maybe some comments would be a good idea?

[nikomatsakis]

r? @alexcrichton

[bors]

⌛ Testing commit 296a179 with merge b4b7681...

[bors]

💔 Test failed - status-travis

[rust-highfive]

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:57:34] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:57:34] ; class=Net (12)
[01:58:30] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[01:58:30] ; class=Net (12)
[01:59:26] error: failed to load source for a dependency on `rand`
[01:59:26] Caused by:
[01:59:26]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[01:59:26] 
[01:59:26] Caused by:
[01:59:26] Caused by:
[01:59:26]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[01:59:26] 
[01:59:26] Caused by:
[01:59:26]   curl error: Couldn't resolve host 'github.com'
[01:59:26] ; class=Net (12)
[01:59:26] 
[01:59:26] 
[01:59:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[01:59:26] 
[01:59:26] 
[01:59:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[01:59:26] Build completed unsuccessfully in 1:56:49

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[alexcrichton]

@bors: retry

[alecmocatta]

@RalfJung Agreed. I'll follow up with a PR once I've tested on a few macOS versions, adding in the aforementioned missing flags for Apple's ld, as well as commenting my understanding of its idiosyncrasies.