-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustfmt and RLS #52755
Update rustfmt and RLS #52755
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
RLS is still Edit: RLS uses the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm afraid we also need a Edit: We need |
This comment has been minimized.
This comment has been minimized.
r? @nrc Currently blocked by:
|
This comment has been minimized.
This comment has been minimized.
RLS is still test-fail, will check later
|
r = me when it's ready thank you! |
This comment has been minimized.
This comment has been minimized.
6cfec96
to
4d63c1c
Compare
This comment has been minimized.
This comment has been minimized.
@bors r=nrc |
📌 Commit 9b348c212c75f8366a9d6f83adcaa1cbcb691065 has been approved by |
⌛ Testing commit 9b348c212c75f8366a9d6f83adcaa1cbcb691065 with merge 331b08293878468083a246251424412675a57624... |
💔 Test failed - status-appveyor |
CI failure
Not sure why the toolstate regression leads to a CI failure here. |
Oh we're in the beta week now. Looks like we need to fix the clippy warnings here as well. |
@bors r=nrc |
📌 Commit cab21f1 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@2a9dc24. Direct link to PR: <rust-lang/rust#52755> 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 🎉 rustfmt on windows: build-fail → test-pass. 🎉 rustfmt on linux: build-fail → test-pass.
The final build time difference is below. We see that the second cargo added about 5 minutes on average and 18 minutes at maximum to the build time. cc @alexcrichton #52755 (comment).
|
@alexcrichton cool, great to hear that! |
No description provided.