Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for unexpected region for local data ReStatic #52809

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Add test for unexpected region for local data ReStatic #52809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/test/ui/issue-49579.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.


// compile-pass

#![feature(nll)]
Copy link
Member

@pnkfelix pnkfelix Jul 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test need to utilize #![feature(nll)]? (In other words, is there something in the test itself that requires NLL for it to compile sucessfully?)

Or can we leave that off, and let the compare-mode=nll handle testing that case (and thus get a test for this in both AST-borrowck and NLL modes)

Copy link
Member Author

@davidtwco davidtwco Jul 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not compile without #![feature(nll)]. I'm not sure if it is possible to allow a UI test to compile successfully in one compare mode but fail in another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use #[rustc_error] to support that. There are examples of it elsewhere in the ui/ test suite.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but having said that, there's no reason to worry about it in this case. If the test does not compile w/o #[feature(nll)], that is fine.


fn fibs(n: u32) -> impl Iterator<Item=u128> {
(0 .. n)
.scan((0, 1), |st, _| {
*st = (st.1, st.0 + st.1);
Some(*st)
})
.map(&|(f, _)| f)
}

fn main() {
println!("{:?}", fibs(10).collect::<Vec<_>>());
}