Fix formatting and errors in std::getopts example. #5308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three issues effecting the example in the getopts rustdoc: 1. The blockquote was incorrectly formatted. Fixed by switching to using an explicit markdown code section with ```. 2. The `fail fail_str(f)` would not compile. Fixed by using `fail!()` instead of `fail`. 3. The line `matches.free[0]` produced a compile error about moving from an immutable vector. Fix by using `copy`.
Previous year range of 2011-2013 was based on file creation date. The check_license python script, however, only accepts copyrights starting in 2012 or later.
|
Sorry about the I'm running I will commit the fix separately unless you would like me to rebase it into the previous commit. Not sure what that would do to bors. |
bors
added a commit
that referenced
this pull request
Mar 11, 2013
There were three issues effecting the example in the getopts rustdoc: 1. The blockquote was incorrectly formatted. Fixed by switching to using an explicit markdown code section with ```. 2. The `fail fail_str(f)` would not compile. Fixed by using `fail!()` instead of `fail`. 3. The line `matches.free[0]` produced a compile error about moving from an immutable vector. Fix by using `copy`.
|
Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Update Changelog I also changed the formatting of the changelog for the beta changelog. I can also do this for all the previous releases, if this formatting gets accepted. [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md) r? @Manishearth changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three issues effecting the example in the getopts rustdoc:
an explicit markdown code section with ```.
fail fail_str(f)would not compile. Fixed by usingfail!()insteadof
fail.matches.free[0]produced a compile error about moving froman immutable vector. Fix by using
copy.