Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable a bunch of debuginfo tests. #53154

Closed
wants to merge 1 commit into from
Closed

Re-enable a bunch of debuginfo tests. #53154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/debuginfo/by-value-non-immediate-argument.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-windows
// ignore-tidy-linelength
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// min-lldb-version: 310

// compile-flags:-g
Expand Down
2 changes: 1 addition & 1 deletion src/test/debuginfo/function-arg-initialization.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-windows
// ignore-tidy-linelength
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// min-lldb-version: 310

// This test case checks if function arguments already have the correct value
Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/function-prologue-stepping-regular.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

// min-lldb-version: 310
// ignore-gdb
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// compile-flags:-g

// lldb-command:breakpoint set --name immediate_args
Expand Down
16 changes: 8 additions & 8 deletions src/test/debuginfo/pretty-std.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

// ignore-windows failing on win32 bot
// ignore-freebsd: gdb package too new
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// ignore-android: FIXME(#10381)
// compile-flags:-g
// min-gdb-version 7.7
Expand Down Expand Up @@ -40,14 +39,15 @@
// gdbr-check:$6 = core::option::Option::None

// gdb-command: print os_string
// gdb-check:$7 = "IAMA OS string 😃"
// gdb-check:$7 = "IAMA OS string"
Copy link
Member

@kennytm kennytm Aug 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the emoji essential? #42278 (comment) mentioned something about Unicode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's essential. In my terminal emulator this prints as the emoji, but on CI it seems to print escaped to octals. I did not find a quick way to make print the same everywhere, so I figured that it's better to have a test for the simple case instead of none at all.


// gdb-command: print some_string
// gdb-check:$8 = Some = {"IAMA optional string!"}
// Disabled due to https://github.com/rust-lang/rust/issues/53153
// g d b-command: print some_string
// g d b-check:$8 = Some = {"IAMA optional string!"}

// gdb-command: set print length 5
// gdb-command: print some_string
// gdb-check:$8 = Some = {"IAMA "...}
// g d b-command: set print length 5
// g d b-command: print some_string
// g d b-check:$8 = Some = {"IAMA "...}


// === LLDB TESTS ==================================================================================
Expand Down Expand Up @@ -92,7 +92,7 @@ fn main() {
let string = "IAMA string!".to_string();

// OsString
let os_string = OsString::from("IAMA OS string \u{1F603}");
let os_string = OsString::from("IAMA OS string");

// Option
let some = Some(8i16);
Expand Down