Test with gdb8.2 and add debuginfo printing function call test #53497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@michaelwoerister I want to add this test, but it seems gdb>=8.1 is needed. (I test gdb=8.1.1 only.) Is this PR premature? Or should we update the gdb version of travis? |
|
woops, sorry |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Whoops, sorry for not replying earlier. @tromey, would know best about this topic, I think. |
|
@michaelwoerister Thanks for your reply. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
tromey
suggested changes
Aug 29, 2018
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
You may want to configure with |
|
Also it occurred to me that you probably only want to build gdb. To make this build faster you can disable the other tools in the tree with |
|
@tromey Thanks, I will try your option. After I confirmed |
tromey
reviewed
Sep 6, 2018
| texinfo | ||
|
|
||
| RUN wget http://ftp.gnu.org/gnu/gdb/gdb-8.1.1.tar.gz > /dev/null && \ | ||
| tar -xzvf gdb-8.1.1.tar.gz > /dev/null && \ |
There was a problem hiding this comment.
FWIW, gdb 8.2 was released yesterday: http://lists.gnu.org/archive/html/info-gnu/2018-09/msg00001.html
There was a problem hiding this comment.
... forgot to mention, it includes some Rust fixes; if your patch goes in I'm hoping to use this when testing a patch I am working on.
There was a problem hiding this comment.
Good news! I try gdb8.2.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I found |
|
I confirmed compile test with gdb 8.*. |
|
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I'd prefer to go ahead and switch to 18.10 for ubuntu to naturally get gdb 8.2, we can figure out other version testing later yeah but using ubuntu's official sources has worked well for us historically |
|
☔ The latest upstream changes (presumably #54004) made this pull request unmergeable. Please resolve the merge conflicts. |
TimNN
added
S-waiting-on-author
|
Ping from triage! @fukatani: It looks like this PR needs to be rebased. @tromey: Do you have any open issues with this PR? @alexcrichton: Do I understand your last comment correctly, that this PR should go to 18.10 directly, rather than installing gdb from an "external" repository? |
No, it is fine.
Note that this was done for |
fukatani
force-pushed
the
test-debuginfo-function-call
branch
2 times, most recently
from
b8a4f4d to
c81abde
Compare
XAMPPRocky
added
S-waiting-on-review
|
Ping from triage... @tromey, we eagerly await your review. :) |
Centril
added
S-waiting-on-review
|
I tend to think the |
fukatani
force-pushed
the
test-debuginfo-function-call
branch
from
824ff44 to
e6bbf7e
Compare
|
@bors r+ |
|
📌 Commit e6bbf7e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 11, 2018
Test with gdb8.2 and add debuginfo printing function call test As far as I can see, `print function()` is not tested. It is important feature for debugging.
|
I forgot to rollup, but maybe it isn't a big deal. |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see,
print function()is not tested. It is important feature for debugging.