Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 17 pull requests #54021

Merged
merged 82 commits into from
Sep 7, 2018
Merged

Rollup of 17 pull requests #54021

merged 82 commits into from
Sep 7, 2018

Commits on Aug 15, 2018

  1. Configuration menu
    Copy the full SHA
    5f198a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Configuration menu
    Copy the full SHA
    f4d6362 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Implement Unpin for Box, Rc, and Arc

    Without Boats committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    c3bdd76 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2018

  1. Fix Rc impl.

    Without Boats committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    9ff29d6 View commit details
    Browse the repository at this point in the history
  2. tidy: Use chars for single-character patterns

    Fixes the clippy "single_char_pattern" lint, and (marginally) improves
    performance.
    joshtriplett committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    cd51523 View commit details
    Browse the repository at this point in the history
  3. tidy: Use is_empty() instead of len tests

    Fixes a clippy warning, and improves readability.
    joshtriplett committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    0f40a12 View commit details
    Browse the repository at this point in the history
  4. tidy: Clean up argument handling

    Use `.nth(n)` rather than `.skip(n).next()` (also fixes a clippy
    warning), and use `.into()` and a type signature rather than
    `PathBuf::from`.
    joshtriplett committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    2893a21 View commit details
    Browse the repository at this point in the history
  5. tidy: cargo.rs: Clean up loop to use "for" instead of "while let"

    Eliminates a clippy warning.
    
    Also drop the unnecessary `.peekable()`.
    joshtriplett committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    fb317aa View commit details
    Browse the repository at this point in the history
  6. tidy: extdeps.rs: Clean up loop iteration to use "for"

    Also eliminates a clippy lint.
    joshtriplett committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    896c3ce View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    decc3b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2018

  1. tidy: Use "const" instead of "static, and remove implied 'static li…

    …fetimes
    
    Dropping the redundant lifetimes also eliminates a clippy warning.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    cd20cdf View commit details
    Browse the repository at this point in the history
  2. tidy: Avoid "let ref mut = ..."

    This also eliminates a clippy warning.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    226d79c View commit details
    Browse the repository at this point in the history
  3. tidy: unstable_book.rs: Clean up directory iteration

    Drop unnecessary .into_iter() (also fixing a clippy warning), and use
    path functions to handle file extensions.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    40ea999 View commit details
    Browse the repository at this point in the history
  4. tidy: deps: Hoist a complex multi-line if condition into a let

    This makes the code more readable, and eliminates a clippy warning.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    fc3419c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d5b1dee View commit details
    Browse the repository at this point in the history
  6. tidy: Use an inclusive range rather than a +1 bound

    This improves readability and eliminates a clippy warning.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    87658bb View commit details
    Browse the repository at this point in the history
  7. tidy: features.rs: collect_lib_features: Simplify

    Use `if let` to simplify a match, and use `contains_key` instead of
    `get`.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    0e65aeb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ebdc1bd View commit details
    Browse the repository at this point in the history
  9. tidy: features.rs: Remove a redundant .contains

    The match expression immediately below it checks the same condition.
    joshtriplett committed Sep 2, 2018
    Configuration menu
    Copy the full SHA
    a5c86fe View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Clarify ManuallyDrop docs

    Mention that you can use `into_inner` to drop the contained value.
    tbu- committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    0e62990 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bde429 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Add .git extension to submodule paths missing it

    Fixes a problem where submodules could not be cloned under some git
    configurations. Specifically, when url.git@github.com:.insteadOf =
    https://github.com/ is set.
    tlively committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    482346c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ae2c62 View commit details
    Browse the repository at this point in the history
  3. Refined the example

    MagnumOpus21 authored and Siva Prasad committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    3ae6d06 View commit details
    Browse the repository at this point in the history
  4. Formatting errors rectified

    MagnumOpus21 authored and Siva Prasad committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    efb88b4 View commit details
    Browse the repository at this point in the history
  5. Prefixed no_run to the no_std write macro

    MagnumOpus21 authored and Siva Prasad committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    6c66aeb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    94e8a6a View commit details
    Browse the repository at this point in the history
  7. Added a missing backtick to no std

    MagnumOpus21 authored and Siva Prasad committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    5e70394 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9d440d5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b7c0d32 View commit details
    Browse the repository at this point in the history
  10. propagate build.python into cmake

    If a suitable value of Python is not on PATH, one can still invoke x.py
    manually, which propagates BOOTSTRAP_PYTHON into the bootstrap
    environment.  But building LLVM will abort with error messages about not
    being able to find Python, and instructions to set PYTHON_EXECUTABLE,
    because nothing is done with BOOTSTRAP_PYTHON when invoking cmake.
    Setting build.python in config.toml had no effect in this scenario,
    either
    
    To fix this, let's provide PYTHON_EXECUTABLE when invoking cmake; for
    the "normal" case of Python in PATH, this doesn't alter any behavior.
    For more unusual cases, however, this ensures cmake finds Python
    properly.  (This change also ensures there are no differences between
    what bootstrap is using, and what cmake uses, which may be useful for
    consistency's sake.)
    froydnj committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    62cd02d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    90b7c5a View commit details
    Browse the repository at this point in the history
  12. Add comment.

    Without Boats committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    c82af09 View commit details
    Browse the repository at this point in the history
  13. Remove #[repr(transparent)] from atomics

    Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to
    actually add this attribute to the atomic types. While we continue to
    debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute.
    This should be a more conservative route which leaves us the ability to tweak
    this in the future but in the meantime allows us to continue discussion as well.
    alexcrichton committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    0338d34 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Configuration menu
    Copy the full SHA
    3dab332 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7834c22 View commit details
    Browse the repository at this point in the history
  3. Add // run-pass annotations to all the tests under ui/run-pass/.

    (I may have accidentally added it to some auxilliary crates as well;
    my emacs-macro-based methodology was pretty crude.)
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    0909e0b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    06f36a0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    90241df View commit details
    Browse the repository at this point in the history
  6. Add #![allow(..)] for a slew of lints of migrated run-pass tests, t…

    …o silence stderr output.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    e462c1a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8bcf37d View commit details
    Browse the repository at this point in the history
  8. Add #![allow(improper_ctypes)] to extern-pass-empty.rs; note this t…

    …est seems bogus.
    
    that is, I suspect it should be retired because it is testing behavior
    (namely a `#[repr(C)] struct Empty;`) that, if I understand correctly,
    is undefined.
    
    See also rust-lang#53859.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d18b3bf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    175d7f4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f78b9ad View commit details
    Browse the repository at this point in the history
  11. Add .stderr files for shadowed labels where the point of the test i…

    …s to test such cases.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    90412f1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    dc7685e View commit details
    Browse the repository at this point in the history
  13. Allow illegal_floating_point_literal_pattern. These will need to be u…

    …pdated at some point.
    
    Discussion can be found on rust-lang#41620.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    4a9e55e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    18a77ae View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2bce9b0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f97eea1 View commit details
    Browse the repository at this point in the history
  17. Add #![allow(stable_features)] to ease review.

    That is, opting to ignore stable `#![feature(..)]`, under my theory
    that a reviewer would prefer as much stuff to be bucketed under "ah
    another `#![allow(..)]` here." as possible.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    dc124e4 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5fe0851 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    58af73c View commit details
    Browse the repository at this point in the history
  20. Migrated src/test/run-pass/borrowck to src/test/ui/run-pass.

    Just shuffling files here; the needed updates to content come later.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    65780bc View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4a7c8cc View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    ff8f1a3 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    92dd526 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    76ceedd View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    f3b766d View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    84a02e1 View commit details
    Browse the repository at this point in the history
  27. Allow unions_with_drop_fields for unions with members with destructors

    (or generics that *might* have dtors)
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    8e72955 View commit details
    Browse the repository at this point in the history
  28. Allow illegal_floating_point_literal_pattern. These will need to be u…

    …pdated at some point.
    
    Discussion can be found on rust-lang#41620.
    pnkfelix committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    4973094 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    43eb925 View commit details
    Browse the repository at this point in the history
  30. Fix typos.

    Without Boats committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    972cd8b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. update clippy submodule

    updates to cafef7b
    matthiaskrgr committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    10e7b76 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#53299 - MagnumOpus21:fix-macro-write, r=ste…

    …veklabnik
    
    Updated core/macros.rs to note it works in a no_std environment.
    
    Fixes rust-lang#45797
    This PR updates the documentation of `write!` to note it works in a `no_std` environment, and adds an
    example to showcase this. In a `no_std` environment, the author of the code is responsible for the
    implementation of the `Write` trait. This example will work out of the box with `no_std`, but the
    implementation of `Write` is expected to be provided by the user.
    
    r? @steveklabnik
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    846a0bd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#53376 - frewsxcv:frewsxcv-copy, r=Guillaume…

    …Gomez
    
    Cross reference io::copy and fs::copy in docs.
    
    Fixes rust-lang#52524.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    654c578 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#53455 - llogiq:num-byte-conversion-docs, r=…

    …steveklabnik
    
    Individual docs for {from,to}_*_bytes
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3f2de03 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#53550 - brson:recurring, r=estebank

    librustc_lint: In recursion warning, change 'recurring' to 'recursing'
    
    The existing wording seems incorrect.
    
    Aside: This warning, 'function cannot return without recursing' is not perfectly clear - it implies that the function _can_ return, it's just got to recurse. But really the fn cannot return period. Clearer wording: 'function recurses infinitely; it cannot return'; or 'function is infinitely self-recursive; it cannot return, and this is probably an error'. I like that.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1805f3c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#53860 - pnkfelix:issue-53764-migrate-run-pa…

    …ss-to-ui, r=nikomatsakis
    
    Migrate (some) of run-pass/ to ui
    
    This is a step towards addressing rust-lang#53764. Much still remains.
    
    I went through a large portion of the `*.rs` files that were directly stored into `src/test/run-pass/` and moved them into various subdirectories of a newly created `src/test/ui/run-pass/`.
    
    (yes, it would have perhaps been nice to meld it more directly with directories already in `src/test/ui/`; but the sad truth is that opens up the reality of filename collisions, and one of my short term goals for resolving rust-lang#53764 is to keep the *filenames* invariant, even as their parents directories and contents are mildly revised...)
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3792dbd View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#53874 - withoutboats:pin-ptr-impls, r=RalfJung

    Implement Unpin for Box, Rc, and Arc
    
    Per the discussion in rust-lang#49150, these should implement `Unpin` even if what they point to does not.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3c77043 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#53895 - joshtriplett:tidy-tidy, r=nikomatsakis

    tidy: Cleanups and clippy warning fixes
    
    This eliminates various clippy warnings in the tidy tool, as well as
    making some related cleanups. These changes should not introduce any
    functional differences.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d2a0f98 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#53946 - tbu-:pr_doc_manuallydrop, r=cramertj

    Clarify `ManuallyDrop` docs
    
    Mention that you can use `into_inner` to drop the contained value.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    03de1c4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#53948 - pnkfelix:issue-52934-minimize-clipp…

    …y-test, r=wesleywiser
    
    Minimized clippy test from when NLL disabled two-phase borrows
    
    (Of course anyone even skimming the test will realize that this is an *expansion* of a previously posted [minimization](rust-lang#52934 (comment)).)
    
    Fix rust-lang#52934.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d70e055 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#53959 - tlively:fix-submodules, r=alexcrichton

    Add .git extension to submodule paths missing it
    
    Fixes a problem where submodules could not be cloned under some git
    configurations. Specifically, when url.git@github.com:.insteadOf =
    https://github.com/ is set.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    7e9fb78 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#53966 - ljedrz:mir_dataflow_cleanups, r=est…

    …ebank
    
    A few cleanups and minor improvements to mir/dataflow
    
    - simplify `dot::GraphWalk::edges` and optimize its vector's allocation
    - turn a `kill` loop into `kill_all`
    - remove the `prepost` parameter from `dataflow_path` (it doesn't seem to do anything)
    - a couple of other minor improvements
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    776b90c View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#53967 - froydnj:cmake-python-executable, r=…

    …alexcrichton
    
    propagate build.python into cmake
    
    If a suitable value of Python is not on `PATH`, one can still invoke x.py
    manually, which propagates `BOOTSTRAP_PYTHON` into the bootstrap
    environment.  But building LLVM will abort with error messages about not
    being able to find Python, and instructions to set `PYTHON_EXECUTABLE`,
    because nothing is done with `BOOTSTRAP_PYTHON` when invoking cmake.
    Setting `build.python` in config.toml had no effect in this scenario,
    either
    
    To fix this, let's provide `PYTHON_EXECUTABLE` when invoking cmake; for
    the "normal" case of Python in `PATH`, this doesn't alter any behavior.
    For more unusual cases, however, this ensures cmake finds Python
    properly.  (This change also ensures there are no differences between
    what bootstrap is using, and what cmake uses, which may be useful for
    consistency's sake.)
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1681b15 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#53979 - alexcrichton:remove-repr-transparen…

    …t-atomics-master, r=sfackler
    
    Remove `#[repr(transparent)]` from atomics
    
    Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to
    actually add this attribute to the atomic types. While we continue to
    debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute.
    This should be a more conservative route which leaves us the ability to tweak
    this in the future but in the meantime allows us to continue discussion as well.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9b70ef7 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#53991 - TimDiekmann:fix-unchecked-intrinsic…

    …s, r=oli-obk
    
    Add unchecked_shl/shr check for intrinsics to fix miri's test suit
    
    r? @RalfJung
    
    cc @oli-obk
    
    rust-lang#53697 broke miri's test suite as described in [this comment](rust-lang#53697 (comment)). This PR adds test for the `unchecked_shr/shl` for the intrinsics.
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    dcca8e8 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#53992 - pnkfelix:issue-53764-migrate-run-pa…

    …ss-borrowck-to-ui, r=nikomatsakis
    
    migrate run-pass/borrowck to ui/run-pass
    
    Part of rust-lang#53764
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    12b3826 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#53994 - pnkfelix:issue-53764-migrate-run-pa…

    …ss-dirs-to-ui, r=alexcrichton
    
    migrate run-pass/*/ to ui/run-pass
    
    I think this is all that remains of rust-lang#53764
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ba57ef1 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#54023 - matthiaskrgr:clippy, r=oli-obk

    update clippy submodule
    
    updates to cafef7b
    kennytm committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    87fbf54 View commit details
    Browse the repository at this point in the history