-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 17 pull requests #54021
Rollup of 17 pull requests #54021
Commits on Aug 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5f198a5 - Browse repository at this point
Copy the full SHA 5f198a5View commit details
Commits on Aug 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f4d6362 - Browse repository at this point
Copy the full SHA f4d6362View commit details
Commits on Aug 31, 2018
-
Implement Unpin for Box, Rc, and Arc
Without Boats committedAug 31, 2018 Configuration menu - View commit details
-
Copy full SHA for c3bdd76 - Browse repository at this point
Copy the full SHA c3bdd76View commit details
Commits on Sep 1, 2018
-
Without Boats committed
Sep 1, 2018 Configuration menu - View commit details
-
Copy full SHA for 9ff29d6 - Browse repository at this point
Copy the full SHA 9ff29d6View commit details -
tidy: Use chars for single-character patterns
Fixes the clippy "single_char_pattern" lint, and (marginally) improves performance.
Configuration menu - View commit details
-
Copy full SHA for cd51523 - Browse repository at this point
Copy the full SHA cd51523View commit details -
tidy: Use is_empty() instead of len tests
Fixes a clippy warning, and improves readability.
Configuration menu - View commit details
-
Copy full SHA for 0f40a12 - Browse repository at this point
Copy the full SHA 0f40a12View commit details -
tidy: Clean up argument handling
Use `.nth(n)` rather than `.skip(n).next()` (also fixes a clippy warning), and use `.into()` and a type signature rather than `PathBuf::from`.
Configuration menu - View commit details
-
Copy full SHA for 2893a21 - Browse repository at this point
Copy the full SHA 2893a21View commit details -
tidy: cargo.rs: Clean up loop to use "for" instead of "while let"
Eliminates a clippy warning. Also drop the unnecessary `.peekable()`.
Configuration menu - View commit details
-
Copy full SHA for fb317aa - Browse repository at this point
Copy the full SHA fb317aaView commit details -
tidy: extdeps.rs: Clean up loop iteration to use "for"
Also eliminates a clippy lint.
Configuration menu - View commit details
-
Copy full SHA for 896c3ce - Browse repository at this point
Copy the full SHA 896c3ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for decc3b0 - Browse repository at this point
Copy the full SHA decc3b0View commit details
Commits on Sep 2, 2018
-
tidy: Use "const" instead of "static, and remove implied
'static
li……fetimes Dropping the redundant lifetimes also eliminates a clippy warning.
Configuration menu - View commit details
-
Copy full SHA for cd20cdf - Browse repository at this point
Copy the full SHA cd20cdfView commit details -
tidy: Avoid "let ref mut = ..."
This also eliminates a clippy warning.
Configuration menu - View commit details
-
Copy full SHA for 226d79c - Browse repository at this point
Copy the full SHA 226d79cView commit details -
tidy: unstable_book.rs: Clean up directory iteration
Drop unnecessary .into_iter() (also fixing a clippy warning), and use path functions to handle file extensions.
Configuration menu - View commit details
-
Copy full SHA for 40ea999 - Browse repository at this point
Copy the full SHA 40ea999View commit details -
tidy: deps: Hoist a complex multi-line if condition into a let
This makes the code more readable, and eliminates a clippy warning.
Configuration menu - View commit details
-
Copy full SHA for fc3419c - Browse repository at this point
Copy the full SHA fc3419cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5b1dee - Browse repository at this point
Copy the full SHA d5b1deeView commit details -
tidy: Use an inclusive range rather than a +1 bound
This improves readability and eliminates a clippy warning.
Configuration menu - View commit details
-
Copy full SHA for 87658bb - Browse repository at this point
Copy the full SHA 87658bbView commit details -
tidy: features.rs: collect_lib_features: Simplify
Use `if let` to simplify a match, and use `contains_key` instead of `get`.
Configuration menu - View commit details
-
Copy full SHA for 0e65aeb - Browse repository at this point
Copy the full SHA 0e65aebView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebdc1bd - Browse repository at this point
Copy the full SHA ebdc1bdView commit details -
tidy: features.rs: Remove a redundant .contains
The match expression immediately below it checks the same condition.
Configuration menu - View commit details
-
Copy full SHA for a5c86fe - Browse repository at this point
Copy the full SHA a5c86feView commit details
Commits on Sep 4, 2018
-
Mention that you can use `into_inner` to drop the contained value.
Configuration menu - View commit details
-
Copy full SHA for 0e62990 - Browse repository at this point
Copy the full SHA 0e62990View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bde429 - Browse repository at this point
Copy the full SHA 6bde429View commit details
Commits on Sep 5, 2018
-
Add .git extension to submodule paths missing it
Fixes a problem where submodules could not be cloned under some git configurations. Specifically, when url.git@github.com:.insteadOf = https://github.com/ is set.
Configuration menu - View commit details
-
Copy full SHA for 482346c - Browse repository at this point
Copy the full SHA 482346cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ae2c62 - Browse repository at this point
Copy the full SHA 2ae2c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ae6d06 - Browse repository at this point
Copy the full SHA 3ae6d06View commit details -
Configuration menu - View commit details
-
Copy full SHA for efb88b4 - Browse repository at this point
Copy the full SHA efb88b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c66aeb - Browse repository at this point
Copy the full SHA 6c66aebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e8a6a - Browse repository at this point
Copy the full SHA 94e8a6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e70394 - Browse repository at this point
Copy the full SHA 5e70394View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d440d5 - Browse repository at this point
Copy the full SHA 9d440d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c0d32 - Browse repository at this point
Copy the full SHA b7c0d32View commit details -
propagate build.python into cmake
If a suitable value of Python is not on PATH, one can still invoke x.py manually, which propagates BOOTSTRAP_PYTHON into the bootstrap environment. But building LLVM will abort with error messages about not being able to find Python, and instructions to set PYTHON_EXECUTABLE, because nothing is done with BOOTSTRAP_PYTHON when invoking cmake. Setting build.python in config.toml had no effect in this scenario, either To fix this, let's provide PYTHON_EXECUTABLE when invoking cmake; for the "normal" case of Python in PATH, this doesn't alter any behavior. For more unusual cases, however, this ensures cmake finds Python properly. (This change also ensures there are no differences between what bootstrap is using, and what cmake uses, which may be useful for consistency's sake.)
Configuration menu - View commit details
-
Copy full SHA for 62cd02d - Browse repository at this point
Copy the full SHA 62cd02dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b7c5a - Browse repository at this point
Copy the full SHA 90b7c5aView commit details -
Without Boats committed
Sep 5, 2018 Configuration menu - View commit details
-
Copy full SHA for c82af09 - Browse repository at this point
Copy the full SHA c82af09View commit details -
Remove
#[repr(transparent)]
from atomicsAdded in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to actually add this attribute to the atomic types. While we continue to debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute. This should be a more conservative route which leaves us the ability to tweak this in the future but in the meantime allows us to continue discussion as well.
Configuration menu - View commit details
-
Copy full SHA for 0338d34 - Browse repository at this point
Copy the full SHA 0338d34View commit details
Commits on Sep 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3dab332 - Browse repository at this point
Copy the full SHA 3dab332View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7834c22 - Browse repository at this point
Copy the full SHA 7834c22View commit details -
Add
// run-pass
annotations to all the tests underui/run-pass/
.(I may have accidentally added it to some auxilliary crates as well; my emacs-macro-based methodology was pretty crude.)
Configuration menu - View commit details
-
Copy full SHA for 0909e0b - Browse repository at this point
Copy the full SHA 0909e0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06f36a0 - Browse repository at this point
Copy the full SHA 06f36a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90241df - Browse repository at this point
Copy the full SHA 90241dfView commit details -
Add
#![allow(..)]
for a slew of lints of migrated run-pass tests, t……o silence stderr output.
Configuration menu - View commit details
-
Copy full SHA for e462c1a - Browse repository at this point
Copy the full SHA e462c1aView commit details -
Add
#[allow(improper_ctypes)]
to slew of cases that need e.g. `repr……(C)`. See also rust-lang#53858.
Configuration menu - View commit details
-
Copy full SHA for 8bcf37d - Browse repository at this point
Copy the full SHA 8bcf37dView commit details -
Add
#![allow(improper_ctypes)]
to extern-pass-empty.rs; note this t……est seems bogus. that is, I suspect it should be retired because it is testing behavior (namely a `#[repr(C)] struct Empty;`) that, if I understand correctly, is undefined. See also rust-lang#53859.
Configuration menu - View commit details
-
Copy full SHA for d18b3bf - Browse repository at this point
Copy the full SHA d18b3bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 175d7f4 - Browse repository at this point
Copy the full SHA 175d7f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f78b9ad - Browse repository at this point
Copy the full SHA f78b9adView commit details -
Add
.stderr
files for shadowed labels where the point of the test i……s to test such cases.
Configuration menu - View commit details
-
Copy full SHA for 90412f1 - Browse repository at this point
Copy the full SHA 90412f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc7685e - Browse repository at this point
Copy the full SHA dc7685eView commit details -
Allow illegal_floating_point_literal_pattern. These will need to be u…
…pdated at some point. Discussion can be found on rust-lang#41620.
Configuration menu - View commit details
-
Copy full SHA for 4a9e55e - Browse repository at this point
Copy the full SHA 4a9e55eView commit details -
Allow uses of
#[unsafe_destructor_blind_to_params]
. Should be porte……d to `#[may_dangle]`. See rust-lang#34761.
Configuration menu - View commit details
-
Copy full SHA for 18a77ae - Browse repository at this point
Copy the full SHA 18a77aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bce9b0 - Browse repository at this point
Copy the full SHA 2bce9b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f97eea1 - Browse repository at this point
Copy the full SHA f97eea1View commit details -
Add
#![allow(stable_features)]
to ease review.That is, opting to ignore stable `#![feature(..)]`, under my theory that a reviewer would prefer as much stuff to be bucketed under "ah another `#![allow(..)]` here." as possible.
Configuration menu - View commit details
-
Copy full SHA for dc124e4 - Browse repository at this point
Copy the full SHA dc124e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fe0851 - Browse repository at this point
Copy the full SHA 5fe0851View commit details -
Add unchecked_shl/shr checks for intrinsics
Tim committedSep 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 58af73c - Browse repository at this point
Copy the full SHA 58af73cView commit details -
Migrated
src/test/run-pass/borrowck
tosrc/test/ui/run-pass
.Just shuffling files here; the needed updates to content come later.
Configuration menu - View commit details
-
Copy full SHA for 65780bc - Browse repository at this point
Copy the full SHA 65780bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a7c8cc - Browse repository at this point
Copy the full SHA 4a7c8ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff8f1a3 - Browse repository at this point
Copy the full SHA ff8f1a3View commit details -
Move check out of the match on the intrinsic name
Tim committedSep 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 92dd526 - Browse repository at this point
Copy the full SHA 92dd526View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ceedd - Browse repository at this point
Copy the full SHA 76ceeddView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b766d - Browse repository at this point
Copy the full SHA f3b766dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84a02e1 - Browse repository at this point
Copy the full SHA 84a02e1View commit details -
Allow unions_with_drop_fields for unions with members with destructors
(or generics that *might* have dtors)
Configuration menu - View commit details
-
Copy full SHA for 8e72955 - Browse repository at this point
Copy the full SHA 8e72955View commit details -
Allow illegal_floating_point_literal_pattern. These will need to be u…
…pdated at some point. Discussion can be found on rust-lang#41620.
Configuration menu - View commit details
-
Copy full SHA for 4973094 - Browse repository at this point
Copy the full SHA 4973094View commit details -
Use binary_op_val instead of doing the check manually.
Tim committedSep 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 43eb925 - Browse repository at this point
Copy the full SHA 43eb925View commit details -
Without Boats committed
Sep 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 972cd8b - Browse repository at this point
Copy the full SHA 972cd8bView commit details
Commits on Sep 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 10e7b76 - Browse repository at this point
Copy the full SHA 10e7b76View commit details -
Rollup merge of rust-lang#53299 - MagnumOpus21:fix-macro-write, r=ste…
…veklabnik Updated core/macros.rs to note it works in a no_std environment. Fixes rust-lang#45797 This PR updates the documentation of `write!` to note it works in a `no_std` environment, and adds an example to showcase this. In a `no_std` environment, the author of the code is responsible for the implementation of the `Write` trait. This example will work out of the box with `no_std`, but the implementation of `Write` is expected to be provided by the user. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 846a0bd - Browse repository at this point
Copy the full SHA 846a0bdView commit details -
Rollup merge of rust-lang#53376 - frewsxcv:frewsxcv-copy, r=Guillaume…
…Gomez Cross reference io::copy and fs::copy in docs. Fixes rust-lang#52524.
Configuration menu - View commit details
-
Copy full SHA for 654c578 - Browse repository at this point
Copy the full SHA 654c578View commit details -
Rollup merge of rust-lang#53455 - llogiq:num-byte-conversion-docs, r=…
…steveklabnik Individual docs for {from,to}_*_bytes
Configuration menu - View commit details
-
Copy full SHA for 3f2de03 - Browse repository at this point
Copy the full SHA 3f2de03View commit details -
Rollup merge of rust-lang#53550 - brson:recurring, r=estebank
librustc_lint: In recursion warning, change 'recurring' to 'recursing' The existing wording seems incorrect. Aside: This warning, 'function cannot return without recursing' is not perfectly clear - it implies that the function _can_ return, it's just got to recurse. But really the fn cannot return period. Clearer wording: 'function recurses infinitely; it cannot return'; or 'function is infinitely self-recursive; it cannot return, and this is probably an error'. I like that.
Configuration menu - View commit details
-
Copy full SHA for 1805f3c - Browse repository at this point
Copy the full SHA 1805f3cView commit details -
Rollup merge of rust-lang#53860 - pnkfelix:issue-53764-migrate-run-pa…
…ss-to-ui, r=nikomatsakis Migrate (some) of run-pass/ to ui This is a step towards addressing rust-lang#53764. Much still remains. I went through a large portion of the `*.rs` files that were directly stored into `src/test/run-pass/` and moved them into various subdirectories of a newly created `src/test/ui/run-pass/`. (yes, it would have perhaps been nice to meld it more directly with directories already in `src/test/ui/`; but the sad truth is that opens up the reality of filename collisions, and one of my short term goals for resolving rust-lang#53764 is to keep the *filenames* invariant, even as their parents directories and contents are mildly revised...)
Configuration menu - View commit details
-
Copy full SHA for 3792dbd - Browse repository at this point
Copy the full SHA 3792dbdView commit details -
Rollup merge of rust-lang#53874 - withoutboats:pin-ptr-impls, r=RalfJung
Implement Unpin for Box, Rc, and Arc Per the discussion in rust-lang#49150, these should implement `Unpin` even if what they point to does not.
Configuration menu - View commit details
-
Copy full SHA for 3c77043 - Browse repository at this point
Copy the full SHA 3c77043View commit details -
Rollup merge of rust-lang#53895 - joshtriplett:tidy-tidy, r=nikomatsakis
tidy: Cleanups and clippy warning fixes This eliminates various clippy warnings in the tidy tool, as well as making some related cleanups. These changes should not introduce any functional differences.
Configuration menu - View commit details
-
Copy full SHA for d2a0f98 - Browse repository at this point
Copy the full SHA d2a0f98View commit details -
Rollup merge of rust-lang#53946 - tbu-:pr_doc_manuallydrop, r=cramertj
Clarify `ManuallyDrop` docs Mention that you can use `into_inner` to drop the contained value.
Configuration menu - View commit details
-
Copy full SHA for 03de1c4 - Browse repository at this point
Copy the full SHA 03de1c4View commit details -
Rollup merge of rust-lang#53948 - pnkfelix:issue-52934-minimize-clipp…
…y-test, r=wesleywiser Minimized clippy test from when NLL disabled two-phase borrows (Of course anyone even skimming the test will realize that this is an *expansion* of a previously posted [minimization](rust-lang#52934 (comment)).) Fix rust-lang#52934.
Configuration menu - View commit details
-
Copy full SHA for d70e055 - Browse repository at this point
Copy the full SHA d70e055View commit details -
Rollup merge of rust-lang#53959 - tlively:fix-submodules, r=alexcrichton
Add .git extension to submodule paths missing it Fixes a problem where submodules could not be cloned under some git configurations. Specifically, when url.git@github.com:.insteadOf = https://github.com/ is set.
Configuration menu - View commit details
-
Copy full SHA for 7e9fb78 - Browse repository at this point
Copy the full SHA 7e9fb78View commit details -
Rollup merge of rust-lang#53966 - ljedrz:mir_dataflow_cleanups, r=est…
…ebank A few cleanups and minor improvements to mir/dataflow - simplify `dot::GraphWalk::edges` and optimize its vector's allocation - turn a `kill` loop into `kill_all` - remove the `prepost` parameter from `dataflow_path` (it doesn't seem to do anything) - a couple of other minor improvements
Configuration menu - View commit details
-
Copy full SHA for 776b90c - Browse repository at this point
Copy the full SHA 776b90cView commit details -
Rollup merge of rust-lang#53967 - froydnj:cmake-python-executable, r=…
…alexcrichton propagate build.python into cmake If a suitable value of Python is not on `PATH`, one can still invoke x.py manually, which propagates `BOOTSTRAP_PYTHON` into the bootstrap environment. But building LLVM will abort with error messages about not being able to find Python, and instructions to set `PYTHON_EXECUTABLE`, because nothing is done with `BOOTSTRAP_PYTHON` when invoking cmake. Setting `build.python` in config.toml had no effect in this scenario, either To fix this, let's provide `PYTHON_EXECUTABLE` when invoking cmake; for the "normal" case of Python in `PATH`, this doesn't alter any behavior. For more unusual cases, however, this ensures cmake finds Python properly. (This change also ensures there are no differences between what bootstrap is using, and what cmake uses, which may be useful for consistency's sake.)
Configuration menu - View commit details
-
Copy full SHA for 1681b15 - Browse repository at this point
Copy the full SHA 1681b15View commit details -
Rollup merge of rust-lang#53979 - alexcrichton:remove-repr-transparen…
…t-atomics-master, r=sfackler Remove `#[repr(transparent)]` from atomics Added in rust-lang#52149 the discussion in rust-lang#53514 is showing how we may not want to actually add this attribute to the atomic types. While we continue to debate rust-lang#53514 this commit reverts the addition of the `transparent` attribute. This should be a more conservative route which leaves us the ability to tweak this in the future but in the meantime allows us to continue discussion as well.
Configuration menu - View commit details
-
Copy full SHA for 9b70ef7 - Browse repository at this point
Copy the full SHA 9b70ef7View commit details -
Rollup merge of rust-lang#53991 - TimDiekmann:fix-unchecked-intrinsic…
…s, r=oli-obk Add unchecked_shl/shr check for intrinsics to fix miri's test suit r? @RalfJung cc @oli-obk rust-lang#53697 broke miri's test suite as described in [this comment](rust-lang#53697 (comment)). This PR adds test for the `unchecked_shr/shl` for the intrinsics.
Configuration menu - View commit details
-
Copy full SHA for dcca8e8 - Browse repository at this point
Copy the full SHA dcca8e8View commit details -
Rollup merge of rust-lang#53992 - pnkfelix:issue-53764-migrate-run-pa…
…ss-borrowck-to-ui, r=nikomatsakis migrate run-pass/borrowck to ui/run-pass Part of rust-lang#53764
Configuration menu - View commit details
-
Copy full SHA for 12b3826 - Browse repository at this point
Copy the full SHA 12b3826View commit details -
Rollup merge of rust-lang#53994 - pnkfelix:issue-53764-migrate-run-pa…
…ss-dirs-to-ui, r=alexcrichton migrate run-pass/*/ to ui/run-pass I think this is all that remains of rust-lang#53764
Configuration menu - View commit details
-
Copy full SHA for ba57ef1 - Browse repository at this point
Copy the full SHA ba57ef1View commit details -
Rollup merge of rust-lang#54023 - matthiaskrgr:clippy, r=oli-obk
update clippy submodule updates to cafef7b
Configuration menu - View commit details
-
Copy full SHA for 87fbf54 - Browse repository at this point
Copy the full SHA 87fbf54View commit details