-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilization change for mod.rs #54072
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 7f6b608 has been approved by |
Cc @Centril, this is a stabilization for both 2015 and 2018 editions, which seems fine to me but wanted to confirm (we can change that later if necessary) |
@Mark-Simulacrum Seems fine, unless there is a particular reason why this wouldn't work well on edition 2015 (I'm assuming there isn't). I think our general policy is to reduce technical debt here, which we do by not having to check if something is in edition A or B. That smoother migration and an aura of stability is also achieved is a nice bonus. |
Stabilization change for mod.rs This change is in response to rust-lang#53125. The patch makes the feature accepted and removes the tests that tested the non-accepted status of the feature.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Rollup of 15 pull requests Successful merges: - #52514 (Fix a few AMDGPU related issues) - #53703 (Document .0 to unpack integer from Wrapping) - #53777 (Implemented map_or_else for Result<T, E>) - #54031 (A few cleanups and minor improvements to rustc_passes) - #54046 (Update documentation for fill_buf in std::io::BufRead) - #54064 (`&CStr`, not `CStr`, is the counterpart of `&str`) - #54072 (Stabilization change for mod.rs) - #54073 (docs: Use dollar sign for all bash prompts) - #54074 (simplify ordering for Kind) - #54085 (Remove documentation about proc_macro being bare-bones) - #54087 (rustdoc: Remove generated blanket impls from trait pages) - #54106 (Reexport CheckLintNameResult) - #54107 (Fix typos in libstd hash map) - #54136 (Update LLVM to fix GlobalISel dbg.declare) - #54142 (Recover proper regression test for issue #16278.) Failed merges: r? @ghost
@nikomatsakis I see this pull in the list of the 15 pulls that were merged. Is anything else required from me on this? |
This change is in response to #53125.
The patch makes the feature accepted and removes the tests that tested the
non-accepted status of the feature.