Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls #54850
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Can you add some form of test, @mcr431 ? |
|
Whoa, |
|
@nikomatsakis sorry about that will add a test and update pr this evening. |
matthew-russo
force-pushed
the
fix-54707-trait-function-from-macro
branch
from
dce7980 to
cf60a29
Compare
|
@nikomatsakis added a test, let me know if you'd like any more or if it should be in a different spot. first time adding a new test. |
|
|
||
| trait Foo { | ||
| def_fn!({ println!("bar"); }); | ||
| } |
There was a problem hiding this comment.
Thanks =) I think it'd be good to include in the text the other various places one might use this as well -- e.g., for a free function etc. Skimming the existing tests I did find that macros/macro-interpolation.rs and macros/macro-stmt both test the free fn case but there don't appear to be tests in impls.
There was a problem hiding this comment.
I think it'd be good to just have one single test dedicated to testing that $b can be used as a fn body in all relevant contexts (the other tests are kind of testing a wider variety of things)
There was a problem hiding this comment.
Thanks for the feeback. will update and let you know when its ready
nikomatsakis
added
S-waiting-on-author
matthew-russo
force-pushed
the
fix-54707-trait-function-from-macro
branch
from
cf60a29 to
3447473
Compare
|
@nikomatsakis I made a new test file: |
|
edit: not sure how to change it from S-waiting-on-author to S-waiting-on-review |
|
@bors r+ |
|
📌 Commit 3447473 has been approved by |
bors
added
S-waiting-on-bors
…m-macro, r=nikomatsakis Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Previously parsing trait items only handled opening brace token and semicolon, I added a branch to the match statement that will also handle interpolated blocks.
…m-macro, r=nikomatsakis Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Fix rust-lang#54707 - parse_trait_item_ now handles interpolated blocks as function body decls Previously parsing trait items only handled opening brace token and semicolon, I added a branch to the match statement that will also handle interpolated blocks.
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
Rollup of 9 pull requests Successful merges: - #54747 (codegen_llvm: verify that inline assembly operands are scalars) - #54848 (Better Diagnostic for Trait Object Capture) - #54850 (Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls) - #54858 (second round of refactorings for universes) - #54862 (Implement RFC 2539: cfg_attr with multiple attributes) - #54869 (Fix mobile docs) - #54870 (Stabilize tool lints) - #54893 (Fix internal compiler error on malformed match arm pattern.) - #54904 (Stabilize the `Option::replace` method) Failed merges: - #54909 ( Add chalk rules related to associated type defs) r? @ghost
…nikomatsakis Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls Previously parsing trait items only handled opening brace token and semicolon, I added a branch to the match statement that will also handle interpolated blocks.
|
☀️ Test successful - status-appveyor, status-travis |
Fix #54707 - parse_trait_item_ now handles interpolated blocks as function body decls
Previously parsing trait items only handled opening brace token and semicolon, I added a branch to the match statement that will also handle interpolated blocks.