Point to variable in asm! macro when failing borrowck
#54945
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -1812,6 +1812,7 @@ pub struct InlineAsmOutput { | |||
| pub constraint: Symbol, | |||
| pub is_rw: bool, | |||
| pub is_indirect: bool, | |||
| pub span: Span, | |||
There was a problem hiding this comment.
Looks like there's no need to keep span here additionally, output expressions are already preserved in hir::ExprKind::InlineAsm (the first HirVec<Expr>), so spans can be taken from there.
There was a problem hiding this comment.
This addition is needed in https://github.com/rust-lang/rust/pull/54945/files#diff-5b4d01d26caf43976125ba0f877e78c0 (for the nll output) as we have StatementKind::InlineAsm available only. ExprKind::InlineAsm is accessible for ast-based borrow checker and there it is indeed using the expr.span (https://github.com/rust-lang/rust/pull/54945/files#diff-dc986596b3470440badc6fb1a667adca).
petrochenkov
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 57f10c7 has been approved by |
bors
added
S-waiting-on-bors
Point to variable in `asm!` macro when failing borrowck Fix rust-lang#34940.
Point to variable in `asm!` macro when failing borrowck Fix #34940.
|
☀️ Test successful - status-appveyor, status-travis |
Fix #34940.