Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universes refactor 3 #55305

Merged
merged 11 commits into from
Nov 2, 2018
Merged

universes refactor 3 #55305

merged 11 commits into from
Nov 2, 2018

Commits on Oct 27, 2018

  1. Configuration menu
    Copy the full SHA
    018c515 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    784746f View commit details
    Browse the repository at this point in the history
  3. allow canonicalized regions to carry universe and track max-universe

    But.. we don't really use it for anything right now.
    nikomatsakis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    3ef27d8 View commit details
    Browse the repository at this point in the history
  4. extend query response to potentially contain fresh universes

    The idea here is that an incoming query may refer to some universes,
    and they query response may contain fresh universes that go beyond
    those. When we instantiate the query response in the caller's scope,
    therefore, we map those new universes into fresh universes for the
    caller.
    nikomatsakis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    7f9ab60 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80d9f8b View commit details
    Browse the repository at this point in the history
  6. distinguish user-type annotations from other annotations

    In particular, we don't want to preserve the universes for the `'_`
    variables that appear in there. And we don't expect to find any
    placeholders, which justifies this as harmless.
    
    (In particular, if you have a query like `Foo(!1, !2, ?3)`, then you
    care about the universe of `?3`, since it may control whether `?3 =
    !1` and `?3 = !2` is a valid answer. But without any placeholders, we
    don't really care: any placeholders that would appear in the output
    must therefore come from some fresh universe anyway.)
    nikomatsakis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    bf51840 View commit details
    Browse the repository at this point in the history
  7. apply minimum bounds when checking closure signature

    Required for test expect-fn-supply-fn.rs to pass; otherwise we have
    unconstrained inference variables that get inferred to `'empty`.
    nikomatsakis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    d4e4e37 View commit details
    Browse the repository at this point in the history
  8. select.rs: rustfmt

    nikomatsakis committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    b24b887 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a1be20c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. fix bug in NLL error reporting

    Account for incompatible universes and higher-ranked subtyping.
    nikomatsakis committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    740117f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c244fd7 View commit details
    Browse the repository at this point in the history