-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Value
to Immediate
for miri
#55393
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #54487) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with the nit fixed.
Thanks!
@@ -146,32 +146,32 @@ impl<'tcx, Tag> ScalarMaybeUndef<Tag> { | |||
/// In particular, thanks to `ScalarPair`, arithmetic operations and casts can be entirely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comment still refers to the old name.
LGTM. :) Needs a rebase though. |
ff8b4b2
to
90bfd0f
Compare
done |
@bors r+ |
📌 Commit 90bfd0fcd8b6e86cafea03b2da466a7277ececfc has been approved by |
☔ The latest upstream changes (presumably #55316) made this pull request unmergeable. Please resolve the merge conflicts. |
Co-Authored-By: oli-obk <github35764891676564198441@oli-obk.de>
90bfd0f
to
400f997
Compare
rebased |
@bors r+ |
📌 Commit 400f997 has been approved by |
Rename `Value` to `Immediate` for miri r? @RalfJung
☀️ Test successful - status-appveyor, status-travis |
r? @RalfJung