Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature gate only being checked on first repr attr. #55510

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix feature gate only being checked on first repr attr. #55510

merged 1 commit into from
Nov 7, 2018

Conversation

bitshifter
Copy link
Contributor

Reported in #33158 (comment).

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2018
@eddyb
Copy link
Member

eddyb commented Nov 4, 2018

r? @petrochenkov cc @nagisa @rkruppe @nikomatsakis

@rust-highfive rust-highfive assigned petrochenkov and unassigned eddyb Nov 4, 2018
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2018

📌 Commit d22ae75 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018
RalfJung
RalfJung reviewed Nov 6, 2018
View reviewed changes
src/libsyntax/feature_gate.rs
@@ -1625,7 +1625,7 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
}

ast::ItemKind::Struct(..) => {
if let Some(attr) = attr::find_by_name(&i.attrs[..], "repr") {
for attr in attr::filter_by_name(&i.attrs[..], "repr") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder in how many other cases we have the same problem...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only one that looked like a problem for repr. I don't know about other attributes though.

@bors
Copy link
Contributor

bors commented Nov 7, 2018

⌛ Testing commit d22ae75 with merge 8a06e2aa46b228b854bae84486d4b6798e5a0c6f...

@bors
Copy link
Contributor

bors commented Nov 7, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
 88 1071M   88  950M    0     0  36.7M      0  0:00:29  0:00:25  0:00:04 49.0M
 92 1071M   92  996M    0     0  37.0M      0  0:00:28  0:00:26  0:00:02 46.9M
 97 1071M   97 1042M    0     0  37.4M      0  0:00:28  0:00:27  0:00:01 45.0M
100 1071M  100 1071M    0     0  37.6M      0  0:00:28  0:00:28 --:--:-- 44.5M
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2018
@kennytm
Copy link
Member

kennytm commented Nov 7, 2018

@bors retry

30 min timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 7, 2018
@kennytm
Rollup merge of rust-lang#55510 - bitshifter:repr-feature-gate-fix, r…
0708a6a 
…=petrochenkov

Fix feature gate only being checked on first repr attr.

Reported in rust-lang#33158 (comment).
@kennytm kennytm mentioned this pull request Nov 7, 2018
Merged
bors added a commit that referenced this pull request Nov 7, 2018
@bors
Auto merge of #55746 - kennytm:rollup, r=kennytm
25a42b2 
Rollup of 14 pull requests

Successful merges:

 - #55377 (Slight copy-editing for `std::cell::Cell` docs)
 - #55441 (Remove unused re import in gdb_rust_pretty_printing)
 - #55453 (Choose predicates without inference variables over those with them)
 - #55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild)
 - #55501 (Make `process_obligations`' computation of `completed` optional.)
 - #55510 (Fix feature gate only being checked on first repr attr.)
 - #55609 (Run name-anon-globals after LTO passes as well)
 - #55645 (do not print wrapping ranges like normal ranges in validity diagnostics)
 - #55688 (Standardised names and location of ui issue tests)
 - #55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n")
 - #55702 (Add `aarch64-pc-windows-msvc` to deployed targets)
 - #55728 (Update lldb)
 - #55730 (Use trait impl method span when type param mismatch is due to impl Trait)
 - #55734 (refactor: use shorthand fields)
@bors bors merged commit d22ae75 into rust-lang:master Nov 7, 2018
alexreg pushed a commit to alexreg/rust that referenced this pull request Nov 7, 2018
@bors @alexreg
Auto merge of rust-lang#55746 - kennytm:rollup, r=kennytm
0f0c201 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#55377 (Slight copy-editing for `std::cell::Cell` docs)
 - rust-lang#55441 (Remove unused re import in gdb_rust_pretty_printing)
 - rust-lang#55453 (Choose predicates without inference variables over those with them)
 - rust-lang#55495 (Don't print opt fuel messages to stdout because it breaks Rustbuild)
 - rust-lang#55501 (Make `process_obligations`' computation of `completed` optional.)
 - rust-lang#55510 (Fix feature gate only being checked on first repr attr.)
 - rust-lang#55609 (Run name-anon-globals after LTO passes as well)
 - rust-lang#55645 (do not print wrapping ranges like normal ranges in validity diagnostics)
 - rust-lang#55688 (Standardised names and location of ui issue tests)
 - rust-lang#55692 (-C remark: fix incorrect warning about requiring "--debuginfo" instead of "-C debuginfo=n")
 - rust-lang#55702 (Add `aarch64-pc-windows-msvc` to deployed targets)
 - rust-lang#55728 (Update lldb)
 - rust-lang#55730 (Use trait impl method span when type param mismatch is due to impl Trait)
 - rust-lang#55734 (refactor: use shorthand fields)
@bitshifter bitshifter deleted the repr-feature-gate-fix branch November 8, 2018 11:30
@kennytm kennytm mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bitshifter @rust-highfive @eddyb @petrochenkov @bors @kennytm @RalfJung