Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri: for uniformity, also move memory_deallocated to AllocationExtra #55888

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

RalfJung
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:060849be:start=1542009320871679467,finish=1542009322013149862,duration=1141470395
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:13:24]    Compiling rustc_mir v0.0.0 (/checkout/src/librustc_mir)
[00:13:26] error: unused import: `Size`
[00:13:26]   --> librustc_mir/interpret/machine.rs:20:32
[00:13:26]    |
[00:13:26] 20 | use rustc::ty::{self, layout::{Size, TyLayout}, query::TyCtxtAt};
[00:13:26]    |
[00:13:26]    = note: `-D unused-imports` implied by `-D warnings`
[00:13:26] 
[00:13:40] error: aborting due to previous error
[00:13:40] error: aborting due to previous error
[00:13:40] 
[00:13:40] error: Could not compile `rustc_mir`.
[00:13:40] warning: build failed, waiting for other jobs to finish...
[00:14:25] error: build failed
[00:14:25] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:14:25] expected success, got: exit code: 101
[00:14:25] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1101:9
[00:14:25] travis_fold:end:stage0-rustc

[00:14:25] travis_time:end:stage0-rustc:start=1542009648910514339,finish=1542010197227927856,duration=548317413517


[00:14:25] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:14:25] Build completed unsuccessfully in 0:10:18
[00:14:25] Makefile:28: recipe for target 'all' failed
[00:14:25] make: *** [all] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1db74948
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Nov 12 08:09:57 UTC 2018

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Nov 12, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2018

📌 Commit 3c88cfe has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 12, 2018
miri: for uniformity, also move memory_deallocated to AllocationExtra

r? @oli-obk
kennytm added a commit to kennytm/rust that referenced this pull request Nov 13, 2018
miri: for uniformity, also move memory_deallocated to AllocationExtra

r? @oli-obk
bors added a commit that referenced this pull request Nov 13, 2018
Rollup of 20 pull requests

Successful merges:

 - #55136 (Remove short doc where it starts with a codeblock)
 - #55711 (Format BtreeMap::range_mut example)
 - #55722 (impl_stable_hash_for: support enums and tuple structs with generic parameters)
 - #55754 (Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err)
 - #55804 (rustdoc: don't inline `pub use some_crate` unless directly asked to)
 - #55805 (Move `static_assert!` into librustc_data_structures)
 - #55837 (Make PhantomData #[structural_match])
 - #55840 (Fix TLS errors when downloading stage0)
 - #55843 (add FromIterator<A> to Box<[A]>)
 - #55858 (Small fixes on code blocks in rustdoc)
 - #55863 (Fix a typo in std::panic)
 - #55870 (Fix typos.)
 - #55874 (string: Add documentation for `From` impls)
 - #55879 (save-analysis: Don't panic for macro-generated use globs)
 - #55882 (Reference count `crate_inherent_impls`s return value.)
 - #55888 (miri: for uniformity, also move memory_deallocated to AllocationExtra)
 - #55889 (global allocators: add a few comments)
 - #55896 (Document optimizations enabled by FusedIterator)
 - #55905 (Change `Lit::short_name` to `Lit::literal_name`.)
 - #55908 (Fix their/there grammar nit)
@bors bors merged commit 3c88cfe into rust-lang:master Nov 14, 2018
@RalfJung RalfJung deleted the alloc-extra branch November 30, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants