-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beta backport rollup #56102
beta backport rollup #56102
Commits on Nov 19, 2018
-
Add helpful logging statements.
This commit adds logging statements to `promote_consts` and `qualify_consts` to make it easier to understand what it is doing.
Configuration menu - View commit details
-
Copy full SHA for bd27131 - Browse repository at this point
Copy the full SHA bd27131View commit details -
Test for cast causing static promotion failure.
This commit adds a test that ensures that a cast in a static doesn't stop const promotion within the static.
Configuration menu - View commit details
-
Copy full SHA for 6c1d718 - Browse repository at this point
Copy the full SHA 6c1d718View commit details -
Refactor and add
PlaceContext::AscribeUserTy
.This commit refactors `PlaceContext` to split it into four different smaller enums based on if the context represents a mutating use, non-mutating use, maybe-mutating use or a non-use (this is based on the recommendation from @oli-obk on Zulip[1]). This commit then introduces a `PlaceContext::AscribeUserTy` variant. `StatementKind::AscribeUserTy` is now correctly mapped to `PlaceContext::AscribeUserTy` instead of `PlaceContext::Validate`. `PlaceContext::AscribeUserTy` can also now be correctly categorized as a non-use which fixes an issue with constant promotion in statics after a cast introduces a `AscribeUserTy` statement. [1]: https://rust-lang.zulipchat.com/#narrow/stream/122657-wg-nll/subject/.2355288.20cast.20fails.20to.20promote.20to.20'static/near/136536949
Configuration menu - View commit details
-
Copy full SHA for 0c3dfe1 - Browse repository at this point
Copy the full SHA 0c3dfe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6f4c8 - Browse repository at this point
Copy the full SHA 8a6f4c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 410f520 - Browse repository at this point
Copy the full SHA 410f520View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84afecc - Browse repository at this point
Copy the full SHA 84afeccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a26e79 - Browse repository at this point
Copy the full SHA 0a26e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab3b0f - Browse repository at this point
Copy the full SHA 9ab3b0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4541827 - Browse repository at this point
Copy the full SHA 4541827View commit details -
Increase
Duration
approximate equal threshold to 1usPreviously this threshold when testing was 100ns, but the Windows documentation states: > which is a high resolution (<1us) time stamp which presumably means that we could have up to 1us resolution, which means that 100ns doesn't capture "equivalent" time intervals due to various bits of rounding here and there. It's hoped that this.. Closes rust-lang#56034
Configuration menu - View commit details
-
Copy full SHA for 1d1213f - Browse repository at this point
Copy the full SHA 1d1213fView commit details
Commits on Nov 20, 2018
-
squashed form of rust-lang#54145
Give each PathSegment a NodeId Store a resolved def on hir::PathSegment save-analysis: remove hacky, unnecessary code now that we have spans for every ident dump data for prefix path segments dump refs for path segments in save-analysis Requires adding path segments to the hir map Fix tests and rustdoc save-analysis: handle missing field names FIxes rust-lang/rls#1031 rebasing and reviewer changes Primarily refactoring `(Ident, Option<NodeId>)` to `Segment` Fix tests and assertions; add some comments more reviewer changes
Configuration menu - View commit details
-
Copy full SHA for e2a9ee4 - Browse repository at this point
Copy the full SHA e2a9ee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14bf347 - Browse repository at this point
Copy the full SHA 14bf347View commit details -
Configuration menu - View commit details
-
Copy full SHA for beb61b4 - Browse repository at this point
Copy the full SHA beb61b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9201260 - Browse repository at this point
Copy the full SHA 9201260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af0260 - Browse repository at this point
Copy the full SHA 0af0260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 396e009 - Browse repository at this point
Copy the full SHA 396e009View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90580ca - Browse repository at this point
Copy the full SHA 90580caView commit details -
Add temporary renames to manifests for rustfmt/clippy
This will be part of our strategy for shipping renamed versions of these components for the Rust 2018 edition. Closes rust-lang#55967
Configuration menu - View commit details
-
Copy full SHA for ddeb85f - Browse repository at this point
Copy the full SHA ddeb85fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8feb63 - Browse repository at this point
Copy the full SHA c8feb63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 224eb83 - Browse repository at this point
Copy the full SHA 224eb83View commit details -
Configuration menu - View commit details
-
Copy full SHA for beaf59f - Browse repository at this point
Copy the full SHA beaf59fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a830c06 - Browse repository at this point
Copy the full SHA a830c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46dd614 - Browse repository at this point
Copy the full SHA 46dd614View commit details -
Configuration menu - View commit details
-
Copy full SHA for feede07 - Browse repository at this point
Copy the full SHA feede07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74bcc4c - Browse repository at this point
Copy the full SHA 74bcc4cView commit details -
Fix Rustdoc ICE when checking blanket impls
Fixes rust-lang#55001, rust-lang#54744 Previously, SelectionContext would unconditionally cache the selection result for an obligation. This worked fine for most users of SelectionContext, but it caused an issue when used by Rustdoc's blanket impl finder. The issue occured when SelectionContext chose a ParamCandidate which contained inference variables. Since inference variables can change between calls to select(), it's not safe to cache the selection result - the chosen candidate might not be applicable for future results, leading to an ICE when we try to run confirmation. This commit prevents SelectionContext from caching any ParamCandidate that contains inference variables. This should always be completely safe, as trait selection should never depend on a particular result being cached. I've also added some extra debug!() statements, which I found helpful in tracking down this bug.
Configuration menu - View commit details
-
Copy full SHA for 01e090d - Browse repository at this point
Copy the full SHA 01e090dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f84c8e - Browse repository at this point
Copy the full SHA 0f84c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ea8c58 - Browse repository at this point
Copy the full SHA 5ea8c58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8129c41 - Browse repository at this point
Copy the full SHA 8129c41View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c93e7 - Browse repository at this point
Copy the full SHA e6c93e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93704f2 - Browse repository at this point
Copy the full SHA 93704f2View commit details