Fix underflow in char_range_at_reverse #5611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, accidentally pushed the wrong branch. But wanted to make a later PR containing those fns anyway, so should I keep it? |
|
Ugh, hold on test errors... |
|
@Kimundi 344d54e looks like a separate change, so if you could, please just do a force-push to this branch so that it only contains the underflow change, and then do another pull request with 344d54e in it later. Thanks! |
|
@catamorphism done, that was silly of me. On the plus site I learned about |
Added char_range_at_reverse underflow test
bors
added a commit
that referenced
this pull request
Mar 31, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 27, 2020
Add to the list of words clippy::doc_markdown ignores "TypeScript" is the only one of these I actually ran into organically; I can remove the others if they're too much. changelog: Add to the list of words `clippy::doc_markdown` ignores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.