-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update books for Rust 2018 #56118
Update books for Rust 2018 #56118
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
📌 Commit 6ce68bb9767ea24a35bcd3dcc24ab893c05ea58a has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors: r- |
6ce68bb
to
d7b3f5c
Compare
This should be fixed, let's see what travis says, and then I'll r+ |
@bors r=alexcrichton |
📌 Commit d7b3f5c has been approved by |
Update books for Rust 2018 This PR: 1. updates all of the books * I don't know if @gankro has further plans for the nomicon or not 2. updates the build process because TRPL is only distributing one edition now 3. fixes up the stdlib links I think that this passes but it's 3:20 am and so I'm sending it in and will fix up anything i missed in the morning. /cc @alexcrichton for the big beta backport
yeah the nomicon is gonna suuuuper use all the time it has before the edition officially ships |
☀️ Test successful - status-appveyor, status-travis |
Tested on commit rust-lang/rust@910ec6d. Direct link to PR: <rust-lang/rust#56118> 🎉 nomicon on windows: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra). 🎉 nomicon on linux: test-fail → test-pass (cc @frewsxcv @gankro, @rust-lang/infra).
HOW |
wait what is that |
[beta] Rollup backports * #56163: [master] Backport 1.30.1 release notes * #56147: resolve: Fix some asserts in import validation * #56118: Update books for Rust 2018 * #56117: resolve: Make "empty import canaries" invisible from other crates * #56065: Replace the ICEing on const fn loops with an error * #56143: Issue 56128 segment id ice nightly * #56134: Fix clippy documentation links (first in #56156) r? @ghost
This PR:
I think that this passes but it's 3:20 am and so I'm sending it in and will fix up anything i missed in the morning.
/cc @alexcrichton for the big beta backport