Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various aspects around let bindings inside const functions #56160

Merged
merged 25 commits into from
Dec 18, 2018
Merged

Fix various aspects around let bindings inside const functions #56160

merged 25 commits into from
Dec 18, 2018

Commits on Nov 30, 2018

  1. Stabilize const_let inside const functions

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    4d2bed9 View commit details
    Browse the repository at this point in the history

  2. Update a test's diagnostics

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    dba5ba0 View commit details
    Browse the repository at this point in the history

  3. Update compile-fail test

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    df2123c View commit details
    Browse the repository at this point in the history

  4. Remove a bunch of now-unnecessary const_let feature gates

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    52b67b1 View commit details
    Browse the repository at this point in the history

  5. Add a test for various const let features

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    ef38afc View commit details
    Browse the repository at this point in the history

  6. Also test the const_let feature gate in statics

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    59c6c49 View commit details
    Browse the repository at this point in the history

  7. Add tests for mutable borrows

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    7ec3c10 View commit details
    Browse the repository at this point in the history

  8. Allow let bindings everywhere

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d62bcad View commit details
    Browse the repository at this point in the history

  9. Properly name the flag for && -> & conversion

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    507ea97 View commit details
    Browse the repository at this point in the history

  10. Show auto-applicable correction warning for short circuiting in const… 

    …ants
    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    75ce28a View commit details
    Browse the repository at this point in the history

  11. Improve the error around short circuiting and let bindings

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d8ece18 View commit details
    Browse the repository at this point in the history

  12. Add a test for single variant matches

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    866664c View commit details
    Browse the repository at this point in the history

  13. Reenable const_let feature gate

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8937faa View commit details
    Browse the repository at this point in the history

  14. Improve the diagnostic message

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    16d2a92 View commit details
    Browse the repository at this point in the history

  15. Fix a compile-fail test

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    ac47bd7 View commit details
    Browse the repository at this point in the history

  16. Remove unused feature gate from libcore

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    25d1c07 View commit details
    Browse the repository at this point in the history

  17. Re-add accidentally deleted test

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    172b428 View commit details
    Browse the repository at this point in the history

  18. Add trailing newline

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    42e5317 View commit details
    Browse the repository at this point in the history

  19. Test float assign ops

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9d2f97b View commit details
    Browse the repository at this point in the history

  20. Fix rebase fallout

    @oli-obk
    oli-obk committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    e6e08c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Undo a change that got lost in the larger refactorings

    @oli-obk
    oli-obk committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    07345f0 View commit details
    Browse the repository at this point in the history

  2. Manually inline trivial function

    @oli-obk
    oli-obk committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    2cb5e3d View commit details
    Browse the repository at this point in the history

  3. Correct documentation about FakeRead

    @oli-obk
    oli-obk committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    6ca2ad5 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Properly worded diagnostic message

    @oli-obk
    oli-obk committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    b678238 View commit details
    Browse the repository at this point in the history

  2. Explain that lack of short circuiting support in constants is temporary

    @oli-obk
    oli-obk committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    d815e2b View commit details
    Browse the repository at this point in the history