-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #56237: normalize type before deferred sizedness checking. #56282
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r+ p=1 |
📌 Commit 8cab350 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Discussed at T-compiler meeting. accepted for backport to beta. |
@pnkfelix shall I prepare the backport by myself, or should I just wait for someone to do this? |
[beta] Rollup backports PRs accepted for backport: * #56781: Update LLVM submodule * #56615: Update the book to fix some edition-related bugs * #56562: Update libc version required by rustc * #56282: Fix #56237: normalize type before deferred sizedness checking. * Release notes for Rust 1.31.1 Approved PRs targeting beta: * #56819: [beta] rustdoc: fix line numbers display for [src] pages * #56893: [beta] Revert "Update CI-clang to 7.0.0 for Linux dists." r? @ghost
@pnkfelix thanks, then I'll leave it untouched. |
This seems to fix #56237, which was introduced by #56045. I don't thoroughly understand how this works, but the problem seemed to be a lack of normalization.
r? @cramertj