Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay gensym creation for "underscore items" (use foo as _/const _) until name resolution #56392

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Delay gensym creation for "underscore items" (use foo as _/const _) until name resolution #56392

merged 3 commits into from
Dec 6, 2018

Commits on Dec 2, 2018

  1. resolve: Avoid "self-confirming" resolutions in import validation

    @petrochenkov
    petrochenkov committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    c658d73 View commit details
    Browse the repository at this point in the history

  2. Delay gensym creation for "underscore items" until name resolution 

    Prohibit `static _`
Fis unused import warnings for `use foo as _`
Add more tests for `use foo as _`
    @petrochenkov
    petrochenkov committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    2d4b633 View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @petrochenkov
    petrochenkov committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    eb1d2e6 View commit details
    Browse the repository at this point in the history