-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention raw-ident syntax #56424
Merged
Merged
Mention raw-ident syntax #56424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 2, 2018
Centril
reviewed
Dec 2, 2018
@bors r+ rollup |
📌 Commit 1fca907 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 2, 2018
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 2, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
bors
added a commit
that referenced
this pull request
Dec 2, 2018
Rollup of 14 pull requests Successful merges: - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks) - #56305 (update miri) - #56366 (Stabilize self_in_typedefs feature) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56394 (Deal with EINTR in net timeout tests) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56424 (Mention raw-ident syntax) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) Failed merges: r? @ghost
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Dec 2, 2018
pietroalbini
added
S-blocked
Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 2, 2018
Centril
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-blocked
Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
labels
Dec 3, 2018
@mark-i-m Can you fix this PR to just include the last commit? |
@Centril I assume you mean the last two? I rebased. |
📌 Commit 0b40be6 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 4, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 4, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Dec 5, 2018
Mention raw-ident syntax According to rust-lang#56419 (review) Blocked on rust-lang#56419 r? @Centril
bors
added a commit
that referenced
this pull request
Dec 5, 2018
Rollup of 15 pull requests Successful merges: - #51753 (Document `From` implementations) - #55563 (Improve no result found sentence in doc search) - #55987 (Add Weak.ptr_eq) - #56119 (Utilize `?` instead of `return None`.) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56388 (More MIR borrow check cleanup) - #56424 (Mention raw-ident syntax) - #56452 (Remove redundant clones) - #56456 (Handle existential types in dead code analysis) - #56466 (data_structures: remove tuple_slice) - #56476 (Fix invalid line number match) - #56497 (cleanup: remove static lifetimes from consts in libstd) - #56498 (Fix line numbers display) - #56523 (Added a bare-bones eslint config (removing jslint)) - #56538 (Use inner iterator may_have_side_effect for Cloned) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #56419 (review)
Blocked on #56419
r? @Centril