Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change untagged_unions to not allow union fields with drop #56440

Closed
wants to merge 9 commits into from
Closed

Change untagged_unions to not allow union fields with drop #56440

wants to merge 9 commits into from

Commits on Jan 12, 2019

  1. Change untagged_unions to not allow union fields with drop 

    Union fields may now never have a type with attached destructor.
This for example allows unions to use arbitrary field types only by wrapping
them in ManuallyDrop.

The stable rule remains, that union fields must be Copy. We use the new
rule for the `untagged_union` feature.

See RFC 2514.
    @bluss
    bluss committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    acf82c7 View commit details
    Browse the repository at this point in the history

  2. Update libcore/std for union fields with drop 

    We now use ManuallyDrop for equivalent effect.
    @bluss
    bluss committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    bfac2f7 View commit details
    Browse the repository at this point in the history

  3. Update tests for union fields with drop rule change

    @bluss
    bluss committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    d17e54f View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. Use union field's span and emit a note for helping about ManuallyDrop

    @bluss
    bluss committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    776d5d4 View commit details
    Browse the repository at this point in the history

  2. Update ui tests for union fields with drop rule change 

    Note: We can't test move out through Box's deref-move since we can't
have a Box in a union anymore.
    @bluss
    bluss committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    0950bdf View commit details
    Browse the repository at this point in the history

  3. Fix additional run-pass tests for no drop in union

    @bluss
    bluss committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    f4b2d71 View commit details
    Browse the repository at this point in the history

  4. Add note to TyS::needs_drop about union dependency on it 

    For now, part of unstable feature untagged_unions.
    @bluss
    bluss committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    87c66a8 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Update union ui tests for manuallydrop note change

    @bluss
    bluss committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    acd71e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2019

  1. Update smallvec to 0.6.8

    @bluss
    bluss committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    0eda54f View commit details
    Browse the repository at this point in the history