-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded extra chars to reduce search-index size #56709
Conversation
The You're also not accounting for combined characters, so this will cut between a letter and a combined accent if it happens to land on that boundary. Since this is going to be used for user-displayed text, i'd prefer it if this used a smarter means of collecting characters (maybe use |
Arf, I thought combined accent was accounted for one char in Rust (which is why I did it this way...). I'll add a parameter to only do it when required. |
Nah, |
Then I can just split on whitespaces and as long as we're under the limit, we'll add the word. |
57929eb
to
3ca2714
Compare
Updated. |
be9a4db
to
50a274a
Compare
50a274a
to
987bf2e
Compare
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now, thanks so much!
r=me when travis is green. |
@bors: r=QuietMisdreavus |
📌 Commit 987bf2e has been approved by |
… r=QuietMisdreavus Remove unneeded extra chars to reduce search-index size Before: ``` 2013782 Dec 11 10:16 build/x86_64-unknown-linux-gnu/doc/search-index.js ``` After: ``` 1736597 Dec 11 10:50 build/x86_64-unknown-linux-gnu/doc/search-index.js ``` No changes in the output of the search. r? @QuietMisdreavus
… r=QuietMisdreavus Remove unneeded extra chars to reduce search-index size Before: ``` 2013782 Dec 11 10:16 build/x86_64-unknown-linux-gnu/doc/search-index.js ``` After: ``` 1736597 Dec 11 10:50 build/x86_64-unknown-linux-gnu/doc/search-index.js ``` No changes in the output of the search. r? @QuietMisdreavus
Rollup of 14 pull requests (first batch) Successful merges: - #56562 (Update libc version required by rustc) - #56609 (Unconditionally emit the target-cpu LLVM attribute.) - #56637 (rustdoc: Fix local reexports of proc macros) - #56658 (Add non-panicking `maybe_new_parser_from_file` variant) - #56695 (Fix irrefutable matches on integer ranges) - #56699 (Use a `newtype_index!` within `Symbol`.) - #56702 ([self-profiler] Add column for percent of total time) - #56708 (Remove some unnecessary feature gates) - #56709 (Remove unneeded extra chars to reduce search-index size) - #56744 (specialize: remove Boxes used by Children::insert) - #56748 (Update panic message to be clearer about env-vars) - #56749 (x86: Add the `adx` target feature to whitelist) - #56756 (Disable btree pretty-printers on older gdbs) - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic) r? @ghost
Before:
After:
No changes in the output of the search.
r? @QuietMisdreavus