-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gpg signing in manifest builder #56735
Conversation
GPG versions 2.x+ require that --batch be passed if --passphrase-fd is to be accepted.
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ p=1 |
📌 Commit 4d5413b has been approved by |
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
⌛ Testing commit 4d5413b with merge 4f081f680e94f190120896119139f5eba48b5d7a... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
…chton Fix gpg signing in manifest builder GPG versions 2.x+ require that --batch be passed if --passphrase-fd is to be accepted. From the man page: --passphrase-fd n Read the passphrase from file descriptor n. Only the first line will be read from file descriptor n. If you use 0 for n, the passphrase will be read from STDIN. This can only be used if only one passphrase is supplied. Note that this passphrase is only used if the option --batch has also been given. This is different from GnuPG version 1.x.
Fix gpg signing in manifest builder GPG versions 2.x+ require that --batch be passed if --passphrase-fd is to be accepted. From the man page: --passphrase-fd n Read the passphrase from file descriptor n. Only the first line will be read from file descriptor n. If you use 0 for n, the passphrase will be read from STDIN. This can only be used if only one passphrase is supplied. Note that this passphrase is only used if the option --batch has also been given. This is different from GnuPG version 1.x.
☀️ Test successful - status-appveyor, status-travis |
[stable] Backport fixes to build-manifest Backports the following changes to stable: * #56703: Fix build of the `build-manifest` tool *(partial, just added last commit)* * #56783: Add `--pinentry-mode=loopback` to deployment script * #56735: Fix gpg signing in manifest builder r? @ghost cc @Mark-Simulacrum @alexcrichton
[beta] Backport fixes to build-manifest Backports the following changes to beta: * #56703: Fix build of the `build-manifest` tool *(partial, just added last commit)* * #56783: Add `--pinentry-mode=loopback` to deployment script * #56735: Fix gpg signing in manifest builder r? @ghost cc @Mark-Simulacrum @alexcrichton
GPG versions 2.x+ require that --batch be passed if --passphrase-fd is
to be accepted.
From the man page: