Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Activate compiler_builtins mem feature for no_std targets #56825

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

alexcrichton
Copy link
Member

This was an accidental regression from #56092, but for no_std targets
being built and distributed we want to be sure to activate the
compiler-builtins mem feature which demangles important memory-related
intrinsics.

This was an accidental regression from rust-lang#56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2018
@alexcrichton
Copy link
Member Author

@bors: p=1

(fixing a regression)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2018

📌 Commit c811915 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2018
@bors
Copy link
Contributor

bors commented Dec 15, 2018

⌛ Testing commit c811915 with merge bcf920f...

bors added a commit that referenced this pull request Dec 15, 2018
std: Activate compiler_builtins `mem` feature for no_std targets

This was an accidental regression from #56092, but for `no_std` targets
being built and distributed we want to be sure to activate the
compiler-builtins `mem` feature which demangles important memory-related
intrinsics.
@bors
Copy link
Contributor

bors commented Dec 15, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bcf920f to master...

@bors bors merged commit c811915 into rust-lang:master Dec 15, 2018
@alexcrichton alexcrichton deleted the demangle-mem branch December 17, 2018 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants