Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically open an issue when a tool breaks #56951

Merged
merged 8 commits into from
Feb 13, 2019
Merged

Automatically open an issue when a tool breaks #56951

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a3abff
Automatically open an issue when a tool breaks
oli-obk Dec 18, 2018
46a8fcd
Automatically tag as nominated for T-compiler
oli-obk Dec 18, 2018
c485acb
Only open one issue per tool
oli-obk Dec 19, 2018
ab5fc7f
Only emit issues for build failures to supress spurious failures
oli-obk Dec 19, 2018
a4c317e
Be more cheerful and helpful
oli-obk Dec 19, 2018
b454474
Tidy
oli-obk Dec 20, 2018
488f16a
Dedent mergebot message
oli-obk Dec 23, 2018
6ed4401
Permit issue posting to have network failures
oli-obk Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions src/tools/publish_toolstate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,42 @@ def read_current_status(current_commit, path):
return json.loads(status)
return {}

def issue(
title,
tool,
maintainers,
relevant_pr_number,
relevant_pr_user,
):
# Open an issue about the toolstate failure.
gh_url = 'https://api.github.com/repos/rust-lang/rust/issues'
assignees = [x.strip() for x in maintainers.split('@') if x != '']
assignees.append(relevant_pr_user)
response = urllib2.urlopen(urllib2.Request(
oli-obk marked this conversation as resolved.
Show resolved Hide resolved
gh_url,
json.dumps({
'body': '''\
kennytm marked this conversation as resolved.
Show resolved Hide resolved
@{}: your PR ({}) broke {}

If you have the time it would be great if you could open a PR against {} that
fixes the fallout from your PR.
'''.format(relevant_pr_user, relevant_pr_number, tool, tool),
'title': title,
'assignees': assignees,
'labels': ['T-compiler', 'I-nominated'],
}),
{
'Authorization': 'token ' + github_token,
'Content-Type': 'application/json',
}
))
response.read()

def update_latest(
current_commit,
relevant_pr_number,
relevant_pr_url,
relevant_pr_user,
current_datetime
):
'''Updates `_data/latest.json` to match build result of the given commit.
Expand Down Expand Up @@ -85,8 +116,11 @@ def update_latest(
.format(tool, os, old, new, MAINTAINERS.get(tool))
elif new < old:
changed = True
message += '💔 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \
.format(tool, os, old, new, MAINTAINERS.get(tool))
title = '💔 {} on {}: {} → {}' \
.format(tool, os, old, new)
message += '{} (cc {}, @rust-lang/infra).\n' \
.format(title, MAINTAINERS.get(tool))
issue(title, tool, MAINTAINERS.get(tool), relevant_pr_number, relevant_pr_user)
kennytm marked this conversation as resolved.
Show resolved Hide resolved

if changed:
status['commit'] = current_commit
Expand All @@ -109,20 +143,23 @@ def update_latest(
save_message_to_path = sys.argv[3]
github_token = sys.argv[4]

relevant_pr_match = re.search('#([0-9]+)', cur_commit_msg)
relevant_pr_match = re.search('Auto merge of #([0-9]+) - ([^:]+)', cur_commit_msg)
if relevant_pr_match:
number = relevant_pr_match.group(1)
relevant_pr_user = relevant_pr_match.group(2)
relevant_pr_number = 'rust-lang/rust#' + number
relevant_pr_url = 'https://github.com/rust-lang/rust/pull/' + number
else:
number = '-1'
relevant_pr_user = '<unknown user>'
relevant_pr_number = '<unknown PR>'
relevant_pr_url = '<unknown>'

message = update_latest(
cur_commit,
relevant_pr_number,
relevant_pr_url,
relevant_pr_user,
cur_datetime
)
if not message:
Expand Down