Allow testing pointers for inboundedness while forbidding dangling pointers #56985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Dec 19, 2018
RalfJung
reviewed
Dec 20, 2018
| } | ||
| InboundsCheck::MaybeDead => self.get_size_and_align(ptr.alloc_id), | ||
| }; | ||
| ptr.check_in_alloc(allocation_size, liveness)?; |
There was a problem hiding this comment.
Is check_in_alloc still used anywhere else? Might be worth to inline it here, because it clearly has a confusing API.
RalfJung
reviewed
Dec 20, 2018
src/librustc_mir/interpret/memory.rs
Outdated
| ptr.check_in_alloc(allocation_size, InboundsCheck::MaybeDead)?; | ||
| let (allocation_size, align) = match liveness { | ||
| InboundsCheck::Live => { | ||
| let alloc = self.get(ptr.alloc_id)?; |
There was a problem hiding this comment.
Won't this error on function pointers?
oli-obk
force-pushed
the
const_check_bounds
branch
from
cfddd36
to
c8bcac5
Compare
|
Still not a fan of @bors r+ |
|
📌 Commit c8bcac5 has been approved by |
bors
added
S-waiting-on-bors
|
Can you formulate your unhappiness with |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 24, 2018
Allow testing pointers for inboundedness while forbidding dangling pointers r? @RalfJung
bors
added a commit
that referenced
this pull request
Dec 24, 2018
Rollup of 10 pull requests Successful merges: - #55470 (box: Add documentation for `From` impls) - #56242 (Add missing link in docs) - #56944 (bootstrap: Link LLVM as a dylib with ThinLTO) - #56978 (Add `std::os::fortanix_sgx` module) - #56985 (Allow testing pointers for inboundedness while forbidding dangling pointers) - #56986 (rustc: Move jemalloc from rustc_driver to rustc) - #57010 (Actually run compiletest tests on CI) - #57021 (Enable emission of alignment attrs for pointer params) - #57074 (Fix recursion limits) - #57085 (librustc_codegen_llvm: Don't eliminate empty structs in C ABI on linux-sparc64) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung