-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodules: update clippy from fc24fce7 to 721f688e #57138
Conversation
|
as of right now, clippy fails to build, I'll update the PR once that has been fixed upstream |
PR updated, should work again. |
I think this'll be included in #56924 |
@oli-obk as of now that PR is updating only Cargo, RLS and Miri and since RLS itself fails due to Clippy's broken build, so technically that PR is blocked on this one :( However, it was hard to coordinate due to several Miri and RLS test failures - could we possibly r+ and p=1 this instead? |
I can include it, but I would prefer to p=1 this one since that big PR is risky and has been difficult to move through. |
@bors r+ p=1 |
📌 Commit c7bbf7a15de54a7f242114a4e11f0e0efa765adc has been approved by |
makes sense. We could also p=1 the bigger PR |
Fixes clippy toolstate Changes: ```` Match on ast/hir::ExprKind::Err Update *.stderr files Use -Zui-testing flag Mention S-inactive-closed PRs in the CONTRIBUTING.md tests: fix formatting and update test output base tests: make sure to fail CI if tests need formatting base tests: switch to nightly toolchain before checking formatting of tests with rustfmt rustup rust-lang#57069 Rustfmt. fix breakage from rust-lang#57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ````
@bors r+ p=1 |
📌 Commit 1654ef8 has been approved by |
⌛ Testing commit 1654ef8 with merge 8a136d9423aae99919c1296cda00ebd4d22b8d9c... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry random testsuite segfault |
#55861 😢 |
submodules: update clippy from fc24fce to 721f688 Fixes clippy toolstate. Changes: ```` rustup #57069 Rustfmt. fix breakage from #57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ```` r? @oli-obk
☀️ Test successful - status-appveyor, status-travis |
📣 Toolstate changed by #57138! Tested on commit d9e3edb. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
Tested on commit rust-lang/rust@d9e3edb. Direct link to PR: <rust-lang/rust#57138> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra). 🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
Fixes clippy toolstate.
Changes:
r? @oli-obk